Changeset 65815 in webkit


Ignore:
Timestamp:
Aug 23, 2010 9:37:01 AM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-08-23 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Remove obsolete public/API methods in chromium port
​https://bugs.webkit.org/show_bug.cgi?id=44421

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition): (WebKit::WebSpeechInputController::cancelRecognition): (WebKit::WebSpeechInputController::stopRecording):
  • public/WebSpeechInputListener.h:
Location:
trunk/WebKit/chromium
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKit/chromium/ChangeLog

    r65787 r65815  
     12010-08-23  Satish Sampath  <satish@chromium.org>
     2
     3        Reviewed by Jeremy Orlow.
     4
     5        Remove obsolete public/API methods in chromium port
     6        https://bugs.webkit.org/show_bug.cgi?id=44421
     7
     8        * public/WebSpeechInputController.h:
     9        (WebKit::WebSpeechInputController::startRecognition):
     10        (WebKit::WebSpeechInputController::cancelRecognition):
     11        (WebKit::WebSpeechInputController::stopRecording):
     12        * public/WebSpeechInputListener.h:
     13
    1142010-08-22  Daniel Bates  <dbates@rim.com>
    215

  • trunk/WebKit/chromium/public/WebSpeechInputController.h

    r65327 r65815  
    4444    virtual bool startRecognition(int)
    4545    {
    46         return startRecognition();
    47     }
    48     // FIXME: Remove this once chromium has picked up this change.
    49     virtual bool startRecognition()
    50     {
    5146        WEBKIT_ASSERT_NOT_REACHED();
    5247        return false;
    … …  
    5550    // Cancels an ongoing recognition and discards any audio recorded so far. No partial
    5651    // recognition results are returned to the listener.
    57     virtual void cancelRecognition(int) { cancelRecognition(); }
    58     // FIXME: Remove this once chromium has picked up this change.
    59     virtual void cancelRecognition() { WEBKIT_ASSERT_NOT_REACHED(); }
     52    virtual void cancelRecognition(int) { WEBKIT_ASSERT_NOT_REACHED(); }
    6053
    6154    // Stops audio recording and performs recognition with the audio recorded until now
    … …  
    6457    // recording 'endpointer' should detect silence in the input and stop recording automatically.
    6558    // Call startRecognition() to record audio and recognize speech again.
    66     virtual void stopRecording(int) { stopRecording(); }
    67     // FIXME: Remove this once chromium has picked up this change.
    68     virtual void stopRecording() { WEBKIT_ASSERT_NOT_REACHED(); }
     59    virtual void stopRecording(int) { WEBKIT_ASSERT_NOT_REACHED(); }
    6960
    7061protected:

  • trunk/WebKit/chromium/public/WebSpeechInputListener.h

    r65327 r65815  
    4949    // in progress.
    5050    virtual void didCompleteRecording(int) = 0;
    51     // FIXME: Remove this once chromium has picked up this change.
    52     virtual void didCompleteRecording()
    53     {
    54         didCompleteRecording(1);
    55     }
    5651
    5752    // Gives results from speech recognition, either partial or the final results.
    … …  
    6055    // or if there was any other errors in the process, this method may never be called.
    6156    virtual void setRecognitionResult(int, const WebString&) = 0;
    62     // FIXME: Remove this once chromium has picked up this change.
    63     virtual void setRecognitionResult(const WebString& result)
    64     {
    65         setRecognitionResult(1, result);
    66     }
    6757
    6858    // Informs that speech recognition has completed. This gets invoked irrespective of whether
    … …  
    7161    // recognition request.
    7262    virtual void didCompleteRecognition(int) = 0;
    73     // FIXME: Remove this once chromium has picked up this change.
    74     virtual void didCompleteRecognition()
    75     {
    76         didCompleteRecognition(1);
    77     }
    7863
    7964protected:
Note: See TracChangeset for help on using the changeset viewer.