Changeset 65844 in webkit

Timestamp:

Aug 23, 2010 4:49:09 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-08-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

fast/xsl/default-html.html fails with HTML5 fragment parsing
​https://bugs.webkit.org/show_bug.cgi?id=44450

This patch is a step down a trail of tears. As far as I can tell,
there's no spec for XSLTProcessor.transformToFragment. This patch
attempts to infer the proper behavior from test cases and the Mozilla
wiki.

• xml/XSLTProcessor.cpp: (WebCore::createFragmentFromSource):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• xml/XSLTProcessor.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-08-23  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        fast/xsl/default-html.html fails with HTML5 fragment parsing
+        https://bugs.webkit.org/show_bug.cgi?id=44450
+
+        This patch is a step down a trail of tears.  As far as I can tell,
+        there's no spec for XSLTProcessor.transformToFragment.  This patch
+        attempts to infer the proper behavior from test cases and the Mozilla
+        wiki.
+
+        * xml/XSLTProcessor.cpp:
+        (WebCore::createFragmentFromSource):
+
 2010-08-23  Adam Barth  <abarth@webkit.org>
 

trunk/WebCore/xml/XSLTProcessor.cpp

@@ -33 +33 @@
 #include "FrameLoader.h"
 #include "FrameView.h"
+#include "HTMLBodyElement.h"
 #include "HTMLDocument.h"
 #include "Page.h"
@@ -100 +101 @@
     RefPtr<DocumentFragment> fragment = outputDoc->createDocumentFragment();
 
-    if (sourceMIMEType == "text/html")
-        fragment->parseHTML(sourceString, 0);
-    else if (sourceMIMEType == "text/plain")
+    if (sourceMIMEType == "text/html") {
+        // As far as I can tell, there isn't a spec for how transformToFragment
+        // is supposed to work.  Based on the documentation I can find, it looks
+        // like we want to start parsing the fragment in the InBody insertion
+        // mode.  Unfortunately, that's an implementation detail of the parser.
+        // We achieve that effect here by passing in a fake body element as
+        // context for the fragment.
+        RefPtr<HTMLBodyElement> fakeBody = HTMLBodyElement::create(outputDoc);
+        fragment->parseHTML(sourceString, fakeBody.get());
+    } else if (sourceMIMEType == "text/plain")
         fragment->parserAddChild(Text::create(outputDoc, sourceString));
     else {