Changeset 65961 in webkit

Timestamp:

Aug 24, 2010 6:09:41 PM (14 years ago)

Author:

ojan@chromium.org

Message:

2010-08-24 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

GC before running an iteration in the perf tests
​https://bugs.webkit.org/show_bug.cgi?id=44570

This is a speculative attempt at reducing flakiness.
There definitely are a lot of collected for some tests,
so, having GC happen in the middle of a run may very well
be causing flakiness.

• resources/magnitude-perf.js: (Magnitude._runIteration): (Magnitude):

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• resources/magnitude-perf.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-08-24  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        GC before running an iteration in the perf tests
+        https://bugs.webkit.org/show_bug.cgi?id=44570
+
+        This is a speculative attempt at reducing flakiness.
+        There definitely are a lot of collected for some tests,
+        so, having GC happen in the middle of a run may very well
+        be causing flakiness.
+
+        * resources/magnitude-perf.js:
+        (Magnitude._runIteration):
+        (Magnitude):
+
 2010-08-24  Tony Chang  <tony@chromium.org>
 

trunk/LayoutTests/resources/magnitude-perf.js

@@ -201 +201 @@
 Magnitude._runIteration = function(setup, test, magnitude, milliseconds, runsPerIteration)
 {
-    Magnitude._debug('run iteration. magnitude ' + magnitude + " milliseconds " + milliseconds + " runsPerIteration " + runsPerIteration);
     setup(magnitude);
+
+    var jsObjectCountBefore = jsObjectCountAfter = 0;
+    if (window.GCController) {
+        jsObjectCountBefore = GCController.getJSObjectCount();
+        GCController.collect();
+        jsObjectCountAfter = GCController.getJSObjectCount();
+    }
+
+    Magnitude._debug('run iteration. magnitude ' + magnitude + " milliseconds " + milliseconds + " runsPerIteration " + runsPerIteration +
+        " jsObjectCountBefore " + jsObjectCountBefore + " jsObjectCountAfter " + jsObjectCountAfter);
 
     var iterations = 0;