Changeset 65978 in webkit


Ignore:
Timestamp:
Aug 24, 2010 10:01:57 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-08-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove HTML5 parser testing infrastructure now that we don't need it
​https://bugs.webkit.org/show_bug.cgi?id=44581

  • html5lib/runner-expected-html5.txt: Removed.
  • html5lib/webkit-resumer-expected-html5.txt: Removed.

2010-08-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove HTML5 parser testing infrastructure now that we don't need it
​https://bugs.webkit.org/show_bug.cgi?id=44581

Just removing dead code, no tests.

  • dom/DocumentFragment.cpp:
  • dom/DocumentFragment.h:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:

2010-08-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove HTML5 parser testing infrastructure now that we don't need it
​https://bugs.webkit.org/show_bug.cgi?id=44581

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2010-08-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove HTML5 parser testing infrastructure now that we don't need it
​https://bugs.webkit.org/show_bug.cgi?id=44581

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): (initializeGlobalsFromCommandLineOptions):
  • Scripts/old-run-webkit-tests:
  • Scripts/test-html5-parser: Removed.
Location:
trunk
Files:
3 deleted
14 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r65976 r65978  
     12010-08-24  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Remove HTML5 parser testing infrastructure now that we don't need it
     6        https://bugs.webkit.org/show_bug.cgi?id=44581
     7
     8        * html5lib/runner-expected-html5.txt: Removed.
     9        * html5lib/webkit-resumer-expected-html5.txt: Removed.
     10
    1112010-08-24  Eric Seidel  <eric@webkit.org>
    212

  • trunk/WebCore/ChangeLog

    r65977 r65978  
     12010-08-24  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Remove HTML5 parser testing infrastructure now that we don't need it
     6        https://bugs.webkit.org/show_bug.cgi?id=44581
     7
     8        Just removing dead code, no tests.
     9
     10        * dom/DocumentFragment.cpp:
     11        * dom/DocumentFragment.h:
     12        * page/Settings.cpp:
     13        (WebCore::Settings::Settings):
     14        * page/Settings.h:
     15
    1162010-08-24  Adam Barth  <abarth@webkit.org>
    217

  • trunk/WebCore/dom/DocumentFragment.cpp

    r65167 r65978  
    7676}
    7777
    78 bool DocumentFragment::shouldUseLegacyHTMLParser() const
    79 {
    80     return document()->page() && document()->page()->settings()
    81         && !document()->page()->settings()->html5ParserEnabled();
    82 }
    83 
    8478void DocumentFragment::parseHTML(const String& source, Element* contextElement, FragmentScriptingPermission scriptingPermission)
    8579{

  • trunk/WebCore/dom/DocumentFragment.h

    r65006 r65978  
    4040    DocumentFragment(Document*);
    4141
    42     bool shouldUseLegacyHTMLParser() const;
    43 
    4442    virtual String nodeName() const;
    4543    virtual NodeType nodeType() const;

  • trunk/WebCore/page/Settings.cpp

    r65868 r65978  
    133133    , m_loadDeferringEnabled(true)
    134134    , m_tiledBackingStoreEnabled(false)
    135     , m_html5ParserEnabled(true)
    136135    , m_paginateDuringLayoutEnabled(false)
    137136    , m_dnsPrefetchingEnabled(true)

  • trunk/WebCore/page/Settings.h

    r65868 r65978  
    308308        void setTiledBackingStoreEnabled(bool);
    309309        bool tiledBackingStoreEnabled() const { return m_tiledBackingStoreEnabled; }
    310 
    311         void setHTML5ParserEnabled(bool flag) { m_html5ParserEnabled = flag; }
    312         bool html5ParserEnabled() const { return m_html5ParserEnabled; }
    313310
    314311        void setPaginateDuringLayoutEnabled(bool flag) { m_paginateDuringLayoutEnabled = flag; }
    … …  
    404401        bool m_loadDeferringEnabled : 1;
    405402        bool m_tiledBackingStoreEnabled : 1;
    406         bool m_html5ParserEnabled: 1;
    407403        bool m_paginateDuringLayoutEnabled : 1;
    408404        bool m_dnsPrefetchingEnabled : 1;

  • trunk/WebKit/mac/ChangeLog

    r65912 r65978  
     12010-08-24  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Remove HTML5 parser testing infrastructure now that we don't need it
     6        https://bugs.webkit.org/show_bug.cgi?id=44581
     7
     8        * WebView/WebPreferenceKeysPrivate.h:
     9        * WebView/WebPreferences.mm:
     10        (+[WebPreferences initialize]):
     11        * WebView/WebPreferencesPrivate.h:
     12        * WebView/WebView.mm:
     13        (-[WebView _preferencesChangedNotification:]):
     14
    1152010-08-24  Sam Weinig  <sam@webkit.org>
    216

  • trunk/WebKit/mac/WebView/WebPreferenceKeysPrivate.h

    r64397 r65978  
    9696#define WebKitPluginAllowedRunTimePreferenceKey @"WebKitPluginAllowedRunTime"
    9797#define WebKitFrameFlatteningEnabledPreferenceKey @"WebKitFrameFlatteningEnabled"
    98 #define WebKitHTML5ParserEnabledPreferenceKey @"WebKitHTML5ParserEnabled"
    99 #define WebKitHTML5TreeBuilderEnabledPreferenceKey @"WebKitHTML5TreeBuilderEnabled" // Temporary, do not use.
    10098#define WebKitPaginateDuringLayoutEnabledPreferenceKey @"WebKitPaginateDuringLayoutEnabled"
    10199#define WebKitDNSPrefetchingEnabledPreferenceKey @"WebKitDNSPrefetchingEnabled"

  • trunk/WebKit/mac/WebView/WebPreferences.mm

    r64802 r65978  
    365365        [NSNumber numberWithUnsignedInt:4], WebKitPluginAllowedRunTimePreferenceKey,
    366366        [NSNumber numberWithBool:NO],   WebKitFrameFlatteningEnabledPreferenceKey,
    367         [NSNumber numberWithBool:YES],  WebKitHTML5ParserEnabledPreferenceKey,
    368         [NSNumber numberWithBool:NO],   WebKitHTML5TreeBuilderEnabledPreferenceKey,
    369367        [NSNumber numberWithBool:YES],  WebKitDNSPrefetchingEnabledPreferenceKey,
    370368        [NSNumber numberWithBool:NO],   WebKitMemoryInfoEnabledPreferenceKey,
    … …  
    12991297}
    13001298
    1301 - (BOOL)html5ParserEnabled
    1302 {
    1303     return [self _boolValueForKey:WebKitHTML5ParserEnabledPreferenceKey];
    1304 }
    1305 
    1306 - (void)setHTML5ParserEnabled:(BOOL)flag
    1307 {
    1308     [self _setBoolValue:flag forKey:WebKitHTML5ParserEnabledPreferenceKey];
    1309 }
    1310 
    1311 - (BOOL)html5TreeBuilderEnabled
    1312 {
    1313     return [self _boolValueForKey:WebKitHTML5TreeBuilderEnabledPreferenceKey];
    1314 }
    1315 
    1316 - (void)setHTML5TreeBuilderEnabled:(BOOL)flag
    1317 {
    1318     [self _setBoolValue:flag forKey:WebKitHTML5TreeBuilderEnabledPreferenceKey];
    1319 }
    1320 
    13211299- (BOOL)paginateDuringLayoutEnabled
    13221300{

  • trunk/WebKit/mac/WebView/WebPreferencesPrivate.h

    r64397 r65978  
    185185- (void)setWebGLEnabled:(BOOL)enabled;
    186186
    187 - (BOOL)html5ParserEnabled;
    188 - (void)setHTML5ParserEnabled:(BOOL)flag;
    189 
    190 // Will be deleted soon, do not use.
    191 - (BOOL)html5TreeBuilderEnabled;
    192 - (void)setHTML5TreeBuilderEnabled:(BOOL)flag;
    193 
    194187- (BOOL)paginateDuringLayoutEnabled;
    195188- (void)setPaginateDuringLayoutEnabled:(BOOL)flag;

  • trunk/WebKit/mac/WebView/WebView.mm

    r65868 r65978  
    14381438    settings->setLoadDeferringEnabled(shouldEnableLoadDeferring());
    14391439    settings->setFrameFlatteningEnabled([preferences isFrameFlatteningEnabled]);
    1440     settings->setHTML5ParserEnabled([preferences html5ParserEnabled]);
    14411440    settings->setPaginateDuringLayoutEnabled([preferences paginateDuringLayoutEnabled]);
    14421441    settings->setMemoryInfoEnabled([preferences memoryInfoEnabled]);

  • trunk/WebKitTools/ChangeLog

    r65966 r65978  
     12010-08-24  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Remove HTML5 parser testing infrastructure now that we don't need it
     6        https://bugs.webkit.org/show_bug.cgi?id=44581
     7
     8        * DumpRenderTree/mac/DumpRenderTree.mm:
     9        (resetDefaultsToConsistentValues):
     10        (initializeGlobalsFromCommandLineOptions):
     11        * Scripts/old-run-webkit-tests:
     12        * Scripts/test-html5-parser: Removed.
     13
    1142010-08-24  Kent Tamura  <tkent@chromium.org>
    215

  • trunk/WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm

    r63536 r65978  
    137137static int dumpTree = YES;
    138138static int forceComplexText;
    139 static int useHTML5Parser = YES;
    140 static int useHTML5TreeBuilder = NO; // Temporary, will be removed.
    141139static BOOL printSeparators;
    142140static RetainPtr<CFStringRef> persistentUserStyleSheetLocation;
    … …  
    457455    [preferences setAcceleratedCompositingEnabled:YES];
    458456    [preferences setWebGLEnabled:NO];
    459     [preferences setHTML5ParserEnabled:useHTML5Parser];
    460     [preferences setHTML5TreeBuilderEnabled:useHTML5TreeBuilder]; // Temporary, will be removed.
    461457
    462458    [[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookieAcceptPolicy:NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain];
    … …  
    565561        {"threaded", no_argument, &threaded, YES},
    566562        {"complex-text", no_argument, &forceComplexText, YES},
    567         {"legacy-parser", no_argument, &useHTML5Parser, NO},
    568         {"html5-treebuilder", no_argument, &useHTML5TreeBuilder, YES},
    569563        {NULL, 0, NULL, 0}
    570564    };

  • trunk/WebKitTools/Scripts/old-run-webkit-tests

    r65737 r65978  
    161161my $testsPerDumpTool = 1000;
    162162my $threaded = 0;
    163 my $html5treebuilder = 0;
    164163# DumpRenderTree has an internal timeout of 30 seconds, so this must be > 30.
    165164my $timeoutSeconds = 35;
    … …  
    302301  --[no-]strip-editing-callbacks  Remove editing callbacks from expected results
    303302  -t|--threaded                   Run a concurrent JavaScript thead with each test
    304   --html5-treebuilder             Run the tests using the HTML5 tree builder
    305303  --timeout t                     Sets the number of seconds before a test times out (default: $timeoutSeconds)
    306304  --valgrind                      Run DumpRenderTree inside valgrind (Qt/Linux only)
    … …  
    346344    'strip-editing-callbacks!' => \$stripEditingCallbacks,
    347345    'threaded|t' => \$threaded,
    348     'html5-treebuilder' => \$html5treebuilder,
    349346    'timeout=i' => \$timeoutSeconds,
    350347    'tolerance=f' => \$tolerance,
    … …  
    579576push @toolArgs, "--pixel-tests" if $pixelTests;
    580577push @toolArgs, "--threaded" if $threaded;
    581 push @toolArgs, "--html5-treebuilder" if $html5treebuilder;
    582578push @toolArgs, "--complex-text" if $complexText;
    583579push @toolArgs, "-";
Note: See TracChangeset for help on using the changeset viewer.