Changeset 65988 in webkit


Ignore:
Timestamp:
Aug 24, 2010 11:52:01 PM (14 years ago)
Author:
tkent@chromium.org
Message:

2010-08-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Pavel Feldman.

[DRT/Chromium] Fix 26 inspector test crashes
​https://bugs.webkit.org/show_bug.cgi?id=44580

  • platform/chromium/drt_expectations.txt:

2010-08-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Pavel Feldman.

[DRT/Chromium] Fix 26 inspector test crashes
​https://bugs.webkit.org/show_bug.cgi?id=44580

  • DRTDevToolsAgent has a reference to the main WebView. So we should not clear it in closeDevTools() and should clear it in ~TestShell().
  • DRTDevToolsClient has a reference to a DevTools WebView and no way to update it. So we should delete DRTDevToolsClient instances in closeDevTools().
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::~TestShell): (TestShell::closeDevTools):
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r65987 r65988  
     12010-08-24  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        [DRT/Chromium] Fix 26 inspector test crashes
     6        https://bugs.webkit.org/show_bug.cgi?id=44580
     7
     8        * platform/chromium/drt_expectations.txt:
     9
    1102010-08-24  Adam Barth  <abarth@webkit.org>
    211

  • trunk/LayoutTests/platform/chromium/drt_expectations.txt

    r65966 r65988  
    209209// Need to implement something?
    210210BUG_DRT WIN : http/tests/inspector-enabled/console-log-before-frame-navigation.html = CRASH
    211 BUG_DRT WIN : http/tests/inspector/console-resource-errors.html = CRASH
    212 BUG_DRT WIN : http/tests/inspector/inspect-iframe-from-different-domain.html = CRASH
    213 BUG_DRT WIN : http/tests/inspector/resource-parameters.html = CRASH
    214 BUG_DRT WIN : inspector/console-assert.html = CRASH
    215 BUG_DRT WIN : inspector/console-command-clear.html = CRASH
    216 BUG_DRT WIN : inspector/console-dir.html = CRASH
    217 BUG_DRT WIN : inspector/console-eval-global.html = CRASH
    218 BUG_DRT WIN : inspector/console-format-collections.html = CRASH
    219 BUG_DRT WIN : inspector/console-log-before-inspector-open.html = CRASH
    220 BUG_DRT WIN : inspector/console-tests.html = CRASH
    221 BUG_DRT WIN : inspector/cookie-resource-match.html = CRASH
     211BUG_DRT WIN : http/tests/inspector/resource-parameters.html = TEXT CRASH PASS
    222212BUG_DRT WIN : inspector/debugger-eval-while-paused.html = CRASH
    223213BUG_DRT WIN : inspector/debugger-no-nested-pause.html = CRASH
    … …  
    229219BUG_DRT WIN : inspector/debugger-step-over.html = CRASH
    230220BUG_DRT WIN : inspector/dom-breakpoints.html = CRASH
    231 BUG_DRT WIN : inspector/elements-panel-limited-children.html = CRASH
    232 BUG_DRT WIN : inspector/elements-panel-search.html = CRASH
    233 BUG_DRT WIN : inspector/elements-panel-structure.html = CRASH
    234 BUG_DRT WIN : inspector/elements-panel-xhtml-structure.xhtml = CRASH
    235 BUG_DRT WIN : inspector/inspected-objects-not-overriden.html = CRASH
    236 BUG_DRT WIN : inspector/styles-disable-inherited.html = CRASH
    237 BUG_DRT WIN : inspector/styles-disable-then-enable.html = CRASH
    238 BUG_DRT WIN : inspector/styles-source-lines-inline.html = CRASH
    239 BUG_DRT WIN : inspector/styles-source-offsets.html = CRASH
    240 BUG_DRT WIN : inspector/syntax-highlight-html.html = CRASH
    241 BUG_DRT WIN : inspector/timeline-enum-stability.html = CRASH
    242 BUG_DRT WIN : inspector/timeline-layout.html = CRASH
    243 BUG_DRT WIN : inspector/timeline-network-resource.html = CRASH
    244 BUG_DRT WIN : inspector/timeline-parse-html.html = CRASH
    245 BUG_DRT WIN : inspector/timeline-script-tag-1.html = CRASH
    246 BUG_DRT WIN : inspector/timeline-trivial.html = CRASH
    247221
    248222

  • trunk/WebKitTools/ChangeLog

    r65984 r65988  
     12010-08-24  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        [DRT/Chromium] Fix 26 inspector test crashes
     6        https://bugs.webkit.org/show_bug.cgi?id=44580
     7
     8        - DRTDevToolsAgent has a reference to the main WebView. So we
     9          should not clear it in closeDevTools() and should clear it in
     10          ~TestShell().
     11        - DRTDevToolsClient has a reference to a DevTools WebView and no
     12          way to update it. So we should delete DRTDevToolsClient instances
     13          in closeDevTools().
     14
     15        * DumpRenderTree/chromium/TestShell.cpp:
     16        (TestShell::~TestShell):
     17        (TestShell::closeDevTools):
     18
    1192010-08-24  Eric Seidel  <eric@webkit.org>
    220

  • trunk/WebKitTools/DumpRenderTree/chromium/TestShell.cpp

    r65966 r65988  
    119119
    120120    // Destroy the WebView before its WebViewHost.
     121    m_drtDevToolsAgent->setWebView(0);
    121122    m_webView->close();
    122123}
    … …  
    146147    if (m_devTools) {
    147148        m_drtDevToolsAgent->reset();
    148         if (m_drtDevToolsClient)
    149             m_drtDevToolsClient->reset();
    150         m_drtDevToolsAgent->setWebView(0);
     149        m_drtDevToolsClient.clear();
    151150        closeWindow(m_devTools);
    152151        m_devTools = 0;
Note: See TracChangeset for help on using the changeset viewer.