Changeset 66205 in webkit

Timestamp:

Aug 27, 2010 5:00:21 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-08-27 Chao-ying Fu <​fu@mips.com>

Reviewed by Oliver Hunt.

Byte alignment issue on MIPS
​https://bugs.webkit.org/show_bug.cgi?id=29415

MIPS accesses one byte at a time for now to avoid the help from the
kernel to fix unaligned accesses.

• wtf/text/AtomicString.cpp: (WebCore::equal):
• wtf/text/StringHash.h: (WebCore::StringHash::equal):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/text/AtomicString.cpp (modified) (1 diff)
• wtf/text/StringHash.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-08-27  Chao-ying Fu  <fu@mips.com>
+
+        Reviewed by Oliver Hunt.
+
+        Byte alignment issue on MIPS
+        https://bugs.webkit.org/show_bug.cgi?id=29415
+
+        MIPS accesses one byte at a time for now to avoid the help from the
+        kernel to fix unaligned accesses.
+
+        * wtf/text/AtomicString.cpp:
+        (WebCore::equal):
+        * wtf/text/StringHash.h:
+        (WebCore::StringHash::equal):
+
 2010-08-27  Xan Lopez  <xlopez@igalia.com>
 

trunk/JavaScriptCore/wtf/text/AtomicString.cpp

@@ -131 +131 @@
     // FIXME: perhaps we should have a more abstract macro that indicates when
     // going 4 bytes at a time is unsafe
-#if CPU(ARM) || CPU(SH4)
+#if CPU(ARM) || CPU(SH4) || CPU(MIPS)
     const UChar* stringCharacters = string->characters();
     for (unsigned i = 0; i != length; ++i) {

trunk/JavaScriptCore/wtf/text/StringHash.h

@@ -56 +56 @@
             // FIXME: perhaps we should have a more abstract macro that indicates when
             // going 4 bytes at a time is unsafe
-#if CPU(ARM) || CPU(SH4)
+#if CPU(ARM) || CPU(SH4) || CPU(MIPS)
             const UChar* aChars = a->characters();
             const UChar* bChars = b->characters();