Changeset 66241 in webkit

Timestamp:

Aug 27, 2010 11:40:39 AM (14 years ago)

Author:

benjamin.poulain@nokia.com

Message:

2010-08-27 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tst_QWebFrame::inputFieldFocus() fails on MeeGo Handset with QtWebKit 2.1
​https://bugs.webkit.org/show_bug.cgi?id=44703

Make the test more robust to changes in the execution environment.
The position where the mouse events are sent is now computed from the element geometry,
this make the test less dependent on the fonts.

The test now also make sure the window manager mapped the window on screen
before attempting to send the events.

• tests/qwebframe/tst_qwebframe.cpp:

Location:

trunk/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• tests/qwebframe/tst_qwebframe.cpp (modified) (2 diffs)

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Qt] tst_QWebFrame::inputFieldFocus() fails on MeeGo Handset with QtWebKit 2.1
+        https://bugs.webkit.org/show_bug.cgi?id=44703
+
+        Make the test more robust to changes in the execution environment.
+        The position where the mouse events are sent is now computed from the element geometry,
+        this make the test less dependent on the fonts.
+
+        The test now also make sure the window manager mapped the window on screen
+        before attempting to send the events.
+
+        * tests/qwebframe/tst_qwebframe.cpp:
+
 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
 

trunk/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp

@@ -2698 +2698 @@
     view.resize(400, 100);
     view.show();
+    QTest::qWaitForWindowShown(&view);
     view.setFocus();
     QTRY_VERIFY(view.hasFocus());
@@ -2705 +2706 @@
 
     // focus the lineedit and check if it blinks
-    QTest::mouseClick(&view, Qt::LeftButton, 0, QPoint(25, 25));
+    const QWebElement inputElement = view.page()->mainFrame()->documentElement().findFirst(QLatin1String("input[type=text]"));
+    QTest::mouseClick(&view, Qt::LeftButton, 0, inputElement.geometry().center());
     m_inputFieldsTestView = &view;
     view.installEventFilter( this );