Changeset 66661 in webkit

Timestamp:

Sep 2, 2010 4:45:15 AM (14 years ago)

Author:

andreas.kling@nokia.com

Message:

2010-09-02 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r66655.
​http://trac.webkit.org/changeset/66655
​https://bugs.webkit.org/show_bug.cgi?id=45104

broke some editing tests (Requested by kling on #webkit).

• page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::selectAllChildren):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DOMSelection.cpp (modified) (3 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-09-02  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r66655.
+        http://trac.webkit.org/changeset/66655
+        https://bugs.webkit.org/show_bug.cgi?id=45104
+
+        broke some editing tests (Requested by kling on #webkit).
+
+        * page/DOMSelection.cpp:
+        (WebCore::DOMSelection::collapse):
+        (WebCore::DOMSelection::selectAllChildren):
+
 2010-09-02  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/WebCore/page/DOMSelection.cpp

@@ -201 +201 @@
 void DOMSelection::collapse(Node* node, int offset, ExceptionCode& ec)
 {
-    Document* selectionDocument = m_frame ? m_frame->document() : 0;
-    Document* nodeDocument = node ? node->document() : 0;
-
-    if (selectionDocument != nodeDocument) {
-        ec = WRONG_DOCUMENT_ERR;
-        return;
-    }
+    if (!m_frame)
+        return;
 
     if (offset < 0) {
@@ -213 +208 @@
         return;
     }
-
-    if (!m_frame)
-        return;
 
     if (!isValidForPosition(node))
@@ -497 +489 @@
         return;
 
-    Document* selectionDocument = m_frame ? m_frame->document() : 0;
-
-    if (selectionDocument != n->document()) {
-        ec = WRONG_DOCUMENT_ERR;
-        return;
-    }
-
     // This doesn't (and shouldn't) select text node characters.
     setBaseAndExtent(n, 0, n, n->childNodeCount(), ec);