Changeset 66663 in webkit


Ignore:
Timestamp:
Sep 2, 2010 5:09:07 AM (14 years ago)
Author:
loislo@chromium.org
Message:

2010-09-01 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: protocol related Inspector's tests are failing in Chromium.

The expectation is different because Chromium tests use test_shell.
1) a lot of console messages automaticaly published by test_shell;
2) debugger was enabled by default;
3) for (i in an_array) produces some garbage.

The solution:
1) override reportProtocolError and console.error functions;
2) debugger was explicitly disabled;
3) just fixed.

​https://bugs.webkit.org/show_bug.cgi?id=44996

  • inspector/report-API-errors.html:
  • inspector/report-protocol-errors.html:
  • LayoutTests/platform/chromium/test_expectations.txt
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r66662 r66663  
     12010-09-01  Ilya Tikhonovsky  <loislo@chromium.org>
     2
     3        Reviewed by Yury Semikhatsky.
     4
     5        WebInspector: protocol related Inspector's tests are failing in Chromium.
     6
     7        The expectation is different because Chromium tests use test_shell.
     8        1) a lot of console messages automaticaly published by test_shell;
     9        2) debugger was enabled by default;
     10        3) for (i in an_array) produces some garbage.
     11
     12        The solution:
     13        1) override reportProtocolError and console.error functions;
     14        2) debugger was explicitly disabled;
     15        3) just fixed.
     16
     17        https://bugs.webkit.org/show_bug.cgi?id=44996
     18
     19        * inspector/report-API-errors.html:
     20        * inspector/report-protocol-errors.html:
     21        * LayoutTests/platform/chromium/test_expectations.txt
     22
    1232010-09-02  Sheriff Bot  <webkit.review.bot@gmail.com>
    224

  • trunk/LayoutTests/inspector/report-API-errors.html

    r66516 r66663  
    66function test()
    77{
    8     function callback()
     8
     9    console.error = function()
    910    {
    1011        InspectorTest.addResult(String.sprintf.apply(this, arguments));
    1112    }
    1213
    13     InspectorTest._addSniffer(console, "error", callback, true);
    14 
    15     InspectorBackend.enableResourceTracking(1, callback);
     14    InspectorBackend.enableResourceTracking(1);
    1615    InspectorBackend.enableResourceTracking();
    1716    InspectorBackend.enableResourceTracking(true, "not a function");

  • trunk/LayoutTests/inspector/report-protocol-errors.html

    r66596 r66663  
    2323    var numberOfReports = 0;
    2424
    25     function callback(message)
     25    WebInspector.reportProtocolError = function(message)
    2626    {
    2727        if (numberOfReports < messages.length)
    … …  
    3232    }
    3333
    34     InspectorTest._addSniffer(WebInspector, "reportProtocolError", callback, true);
    35     for (var message in messages)
    36         InspectorFrontendHost.sendMessageToBackend(messages[message]);
     34    function fire() {
     35        for (var i = 0; i < messages.length; ++i)
     36            InspectorFrontendHost.sendMessageToBackend(messages[i]);
     37    }
     38
     39    InspectorBackend.disableDebugger(true, fire);
    3740}
    3841

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r66641 r66663  
    23842384// Flaky tests found during the roll.
    23852385BUG32679 LINUX DEBUG : http/tests/navigation/lockedhistory-iframe.html = TEXT PASS
    2386 BUG32684 WIN : inspector/timeline-layout.html = TEXT PASS
    23872386BUG32688 MAC DEBUG : fast/lists/inlineBoxWrapperNullCheck.html = TEXT PASS
    23882387BUG32689 MAC LINUX DEBUG : http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html = TEXT PASS
Note: See TracChangeset for help on using the changeset viewer.