Changeset 66681 in webkit


Ignore:
Timestamp:
Sep 2, 2010 1:10:42 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-09-02 Eric Seidel <​eric@webkit.org>

Reviewed by Alexey Proskuryakov.

fast/loader/recursive-before-unload-crash.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=43840

Removed the frame loader callbacks as Brady suggested in
​https://bugs.webkit.org/show_bug.cgi?id=38928#c27
This should stop the flake. As an added bonus this test no longer
needs platform specific results.

  • fast/loader/recursive-before-unload-crash-expected.txt:
  • fast/loader/recursive-before-unload-crash.html:
  • platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt: Removed.
  • platform/mac-tiger/fast/loader/recursive-before-unload-crash-expected.txt: Removed.
Location:
trunk/LayoutTests
Files:
2 deleted
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r66680 r66681  
     12010-09-02  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Alexey Proskuryakov.
     4
     5        fast/loader/recursive-before-unload-crash.html is flaky
     6        https://bugs.webkit.org/show_bug.cgi?id=43840
     7
     8        Removed the frame loader callbacks as Brady suggested in
     9        https://bugs.webkit.org/show_bug.cgi?id=38928#c27
     10        This should stop the flake.  As an added bonus this test no longer
     11        needs platform specific results.
     12
     13        * fast/loader/recursive-before-unload-crash-expected.txt:
     14        * fast/loader/recursive-before-unload-crash.html:
     15        * platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt: Removed.
     16        * platform/mac-tiger/fast/loader/recursive-before-unload-crash-expected.txt: Removed.
     17
    1182010-09-02  Tony Chang  <tony@chromium.org>
    219

  • trunk/LayoutTests/fast/loader/recursive-before-unload-crash-expected.txt

    r59384 r66681  
    1 main frame - didFinishDocumentLoadForFrame
    2 main frame - willPerformClientRedirectToURL: http://127.0.0.1:1234/
    3 main frame - didHandleOnloadEventsForFrame
    4 main frame - didFinishLoadForFrame
    51ALERT: onbeforeunload called, and iframe hasn't been added yet.
    6 main frame - didStartProvisionalLoadForFrame
    72ALERT: Adding iframe
    8 frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
    9 main frame - didCancelClientRedirectForFrame
    10 frame "<!--framePath //<!--frame0-->-->" - didFailProvisionalLoadWithError
    11 main frame - didFailProvisionalLoadWithError
    123This test demonstrates a problem with our handling of the beforeunload event.
    134If a script manages to try and navigate the frame from beforeunload - when a navigation is already pending - we end up blowing out the stack by recursively consulting the policy delegate then running onbeforeunload repeatedly.

  • trunk/LayoutTests/fast/loader/recursive-before-unload-crash.html

    r59384 r66681  
    33    layoutTestController.waitUntilDone();
    44    layoutTestController.dumpAsText();
    5     layoutTestController.dumpFrameLoadCallbacks();
    65}
    76
Note: See TracChangeset for help on using the changeset viewer.