Changeset 66861 in webkit

Timestamp:

Sep 6, 2010 8:13:06 PM (14 years ago)

Author:

Dimitri Glazkov

Message:

2010-09-06 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

[Chromium/DRT] Empty out user stylesheet after each test run.
​https://bugs.webkit.org/show_bug.cgi?id=45282

This should significantly cut down on the number of the mysterious flaky tests
whose diffs looked like the page was blown up to a very lage size. This
was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
which set the base body font to 100px.

Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
the same thread failed.

• DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): Set user stylesheet to an empty URL.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/chromium/TestShell.cpp (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Reviewed by Kent Tamura.
+
+        [Chromium/DRT] Empty out user stylesheet after each test run.
+        https://bugs.webkit.org/show_bug.cgi?id=45282
+
+        This should significantly cut down on the number of the mysterious flaky tests
+        whose diffs looked like the page was blown up to a very lage size. This
+        was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
+        which set the base body font to 100px.
+
+        Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
+        the same thread failed.
+
+        * DumpRenderTree/chromium/TestShell.cpp:
+        (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
+
 2010-09-06  Kent Tamura  <tkent@chromium.org>
 

trunk/WebKitTools/DumpRenderTree/chromium/TestShell.cpp

@@ -205 +205 @@
     settings->setOfflineWebApplicationCacheEnabled(true);
     settings->setAllowFileAccessFromFileURLs(true);
+    settings->setUserStyleSheetLocation(WebURL());
 
     // LayoutTests were written with Safari Mac in mind which does not allow