Changeset 66977 in webkit

Timestamp:

Sep 8, 2010 6:27:44 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-09-08 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Dirk Schulze.

[WML] Add create functions to WML.
​https://bugs.webkit.org/show_bug.cgi?id=44950

There are missing definitions of create function in WML area.
So, there are build breaks when enabling WML. The create functions and the construction
are added. In addition, a style error and duplicated adoptRef usage are fixed.

• wml/WMLDocument.h: (WebCore::WMLDocument::create):
• wml/WMLFormControlElement.h:
• wml/WMLIntrinsicEvent.cpp: (WebCore::WMLIntrinsicEvent::WMLIntrinsicEvent):
• wml/WMLIntrinsicEvent.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• wml/WMLDocument.h (modified) (1 diff)
• wml/WMLFormControlElement.h (modified) (2 diffs)
• wml/WMLIntrinsicEvent.cpp (modified) (1 diff)
• wml/WMLIntrinsicEvent.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        Reviewed by Dirk Schulze.
+
+        [WML] Add create functions to WML.
+        https://bugs.webkit.org/show_bug.cgi?id=44950
+
+        There are missing definitions of create function in WML area. 
+        So, there are build breaks when enabling WML. The create functions and the construction 
+        are added. In addition, a style error and duplicated adoptRef usage are fixed.
+
+        * wml/WMLDocument.h:
+        (WebCore::WMLDocument::create):
+        * wml/WMLFormControlElement.h:
+        * wml/WMLIntrinsicEvent.cpp:
+        (WebCore::WMLIntrinsicEvent::WMLIntrinsicEvent):
+        * wml/WMLIntrinsicEvent.h:
+
 2010-09-08  Nico Weber  <thakis@chromium.org>
 

trunk/WebCore/wml/WMLDocument.h

@@ -35 +35 @@
     static PassRefPtr<WMLDocument> create(Frame* frame, const KURL& url)
     {
-        return adoptRef(adoptRef(new WMLDocument(frame, url))));
+        return adoptRef(new WMLDocument(frame, url));
     }
 

trunk/WebCore/wml/WMLFormControlElement.h

@@ -29 +29 @@
 class WMLFormControlElement : public WMLElement {
 public:
-    WMLFormControlElement(const QualifiedName&, Document*);
+    static PassRefPtr<WMLFormControlElement> create(const QualifiedName&, Document*);
+
+
     virtual ~WMLFormControlElement();
 
@@ -45 +47 @@
     virtual void recalcStyle(StyleChange);
 
+protected:
+    WMLFormControlElement(const QualifiedName&, Document*);
+
 private:
     bool m_valueMatchesRenderer;

trunk/WebCore/wml/WMLIntrinsicEvent.cpp

@@ -44 +44 @@
 }
 
-PassRefPtr<WMLIntrinsicEvent> WMLIntrinsicEvent::create(const QualifiedName& tagName, Document* document)
-{
-    return adoptRef(new WMLIntrinsicEvent(tagName, document));
-}
-
 WMLIntrinsicEvent::WMLIntrinsicEvent(WMLTaskElement* taskElement)
     : m_taskElement(taskElement)

trunk/WebCore/wml/WMLIntrinsicEvent.h

@@ -23 +23 @@
 
 #if ENABLE(WML)
+#include "WMLTaskElement.h"
+
 #include <wtf/PassRefPtr.h>
 #include <wtf/RefCounted.h>
 #include <wtf/RefPtr.h>
-
-#include "WMLTaskElement.h"
 
 namespace WebCore {