Changeset 67111 in webkit

Timestamp:

Sep 9, 2010 1:49:44 PM (14 years ago)

Author:

antonm@chromium.org

Message:

2010-09-09 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] bypass caches when query memory usage from post GC and in crash handler.
​https://bugs.webkit.org/show_bug.cgi?id=45036

Second part of the whole change: now use API introduced in
​http://trac.webkit.org/changeset/66818 and now backed by Chromium.

• bindings/v8/V8DOMWindowShell.cpp: (WebCore::reportFatalErrorInV8):
• bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcEpilogue):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8DOMWindowShell.cpp (modified) (1 diff)
• bindings/v8/V8GCController.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-09-09  Anton Muhin  <antonm@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        [v8] bypass caches when query memory usage from post GC and in crash handler.
+        https://bugs.webkit.org/show_bug.cgi?id=45036
+
+        Second part of the whole change: now use API introduced in
+        http://trac.webkit.org/changeset/66818 and now backed by Chromium.
+
+        * bindings/v8/V8DOMWindowShell.cpp:
+        (WebCore::reportFatalErrorInV8):
+        * bindings/v8/V8GCController.cpp:
+        (WebCore::V8GCController::gcEpilogue):
+
 2010-09-09  Kwang Yul Seo  <skyul@company100.net>
 

trunk/WebCore/bindings/v8/V8DOMWindowShell.cpp

@@ -86 +86 @@
     int memoryUsageMB = -1;
 #if PLATFORM(CHROMIUM)
-    memoryUsageMB = ChromiumBridge::memoryUsageMB();
+    memoryUsageMB = ChromiumBridge::actualMemoryUsageMB();
 #endif
     printf("V8 error: %s (%s).  Current memory usage: %d MB\n", message, location, memoryUsageMB);

trunk/WebCore/bindings/v8/V8GCController.cpp

@@ -407 +407 @@
 }
 
+int getActualMemoryUsageInMB()
+{
+#if PLATFORM(CHROMIUM)
+    return ChromiumBridge::actualMemoryUsageMB();
+#else
+    return 0;
+#endif
+}
+
 }  // anonymous namespace
 
@@ -418 +427 @@
     visitActiveDOMObjectsInCurrentThread(&epilogueVisitor);
 
-    workingSetEstimateMB = getMemoryUsageInMB();
+    workingSetEstimateMB = getActualMemoryUsageInMB();
 
 #ifndef NDEBUG