Changeset 67147 in webkit


Ignore:
Timestamp:
Sep 9, 2010 7:19:00 PM (14 years ago)
Author:
kinuko@chromium.org
Message:

2010-09-09 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

Add Entry.getMetadata for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=45403

Add getMetadata to Entry.idl (I had missed to include this
in my previous Entry.idl patch.)

Also make some minor cleanups and nits fixes.

No new tests; layout test is going be added later.

  • fileapi/DOMFileSystem.cpp: Bug fix.
  • fileapi/MetadataCallback.h: Nits fix.
  • fileapi/Entry.idl: Added getMetadata.
  • fileapi/ErrorCallback.h: Nits fix.
Location:
trunk/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r67145 r67147  
     12010-09-09  Kinuko Yasuda  <kinuko@chromium.org>
     2
     3        Reviewed by Dumitru Daniliuc.
     4
     5        Add Entry.getMetadata for FileSystem API
     6        https://bugs.webkit.org/show_bug.cgi?id=45403
     7
     8        Add getMetadata to Entry.idl (I had missed to include this
     9        in my previous Entry.idl patch.)
     10
     11        Also make some minor cleanups and nits fixes.
     12
     13        No new tests; layout test is going be added later.
     14
     15        * fileapi/DOMFileSystem.cpp: Bug fix.
     16        * fileapi/MetadataCallback.h: Nits fix.
     17        * fileapi/Entry.idl: Added getMetadata.
     18        * fileapi/ErrorCallback.h: Nits fix.
     19
    1202010-09-09  Ryosuke Niwa  <rniwa@webkit.org>
    221

  • trunk/WebCore/fileapi/DOMFileSystem.cpp

    r66586 r67147  
    7979{
    8080    m_asyncFileSystem->stop();
     81    ActiveDOMObject::contextDestroyed();
    8182}
    8283

  • trunk/WebCore/fileapi/Entry.idl

    r66586 r67147  
    3939        readonly attribute DOMFileSystem filesystem;
    4040
     41        void getMetadata(in [Optional, Callback] MetadataCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
    4142        void moveTo(in Entry parent, in [Optional] DOMString name, in [Optional, Callback] EntryCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
    4243        void copyTo(in Entry parent, in [Optional] DOMString name, in [Optional, Callback] EntryCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
    4344        void remove(in [Optional, Callback] VoidCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
    4445        void getParent(in [Optional, Callback] EntryCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
    45         DOMString toURI(in [Optional] DOMString mimeType);
    4646    };
    4747}

  • trunk/WebCore/fileapi/ErrorCallback.h

    r66586 r67147  
    3939
    4040class FileError;
    41 class ScriptExecutionContext;
    4241
    4342class ErrorCallback : public RefCounted<ErrorCallback> {

  • trunk/WebCore/fileapi/MetadataCallback.h

    r66586 r67147  
    3939
    4040class Metadata;
    41 class ScriptExecutionContext;
    4241
    4342class MetadataCallback : public RefCounted<MetadataCallback> {
Note: See TracChangeset for help on using the changeset viewer.