Changeset 67389 in webkit


Ignore:
Timestamp:
Sep 13, 2010 8:25:36 AM (14 years ago)
Author:
Martin Robinson
Message:

2010-09-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Andreas Kling.

[Qt] DOM listeners get wrong keycodes for some keys
​https://bugs.webkit.org/show_bug.cgi?id=43365

  • platform/qt/Skipped: Unskip tests that are now passing.

2010-09-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Andreas Kling.

[Qt] DOM listeners get wrong keycodes for some keys
​https://bugs.webkit.org/show_bug.cgi?id=43365

Produce the proper keycodes for the print screen key as well as the
keypad insert and delete keys.

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent): Fix keycode translation for the mentioned keys.
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r67387 r67389  
     12010-09-13  Martin Robinson  <mrobinson@igalia.com>
     2
     3        Reviewed by Andreas Kling.
     4
     5        [Qt] DOM listeners get wrong keycodes for some keys
     6        https://bugs.webkit.org/show_bug.cgi?id=43365
     7
     8        * platform/qt/Skipped: Unskip tests that are now passing.
     9
    1102010-09-13  Jonathan Dixon  <joth@chromium.org>
    211

  • trunk/LayoutTests/platform/qt/Skipped

    r67386 r67389  
    54215421svg/custom/getscreenctm-in-mixed-content2.xhtml
    54225422
    5423 # [Qt] DOM listeners get wrong keycodes for some keys
    5424 # https://bugs.webkit.org/show_bug.cgi?id=43365
    5425 fast/events/keydown-numpad-keys.html
    5426 fast/events/special-key-events-in-input-text.html
    5427 
    54285423# Still working out flakiness issues with the perf tests.
    54295424# https://bugs.webkit.org/show_bug.cgi?id=44199

  • trunk/WebCore/ChangeLog

    r67387 r67389  
     12010-09-13  Martin Robinson  <mrobinson@igalia.com>
     2
     3        Reviewed by Andreas Kling.
     4
     5        [Qt] DOM listeners get wrong keycodes for some keys
     6        https://bugs.webkit.org/show_bug.cgi?id=43365
     7
     8        Produce the proper keycodes for the print screen key as well as the
     9        keypad insert and delete keys.
     10
     11        * platform/qt/PlatformKeyboardEventQt.cpp:
     12        (WebCore::windowsKeyCodeForKeyEvent): Fix keycode translation for the mentioned keys.
     13
    1142010-09-13  Jonathan Dixon  <joth@chromium.org>
    215

  • trunk/WebCore/platform/qt/PlatformKeyboardEventQt.cpp

    r62654 r67389  
    189189        case Qt::Key_Down:
    190190            return VK_DOWN; // (28) DOWN ARROW key
     191        case Qt::Key_Insert:
     192            return VK_INSERT; // (2D) INS key
     193        case Qt::Key_Delete:
     194            return VK_DELETE; // (2E) DEL key
    191195        default:
    192196            return 0;
    … …  
    305309        return VK_SELECT; // (29) SELECT key
    306310    case Qt::Key_Print:
    307         return VK_PRINT; // (2A) PRINT key
     311        return VK_SNAPSHOT; // (2A) PRINT key
    308312    case Qt::Key_Execute:
    309313        return VK_EXECUTE; // (2B) EXECUTE key
    310         // dunno on this
    311         // case Qt::Key_PrintScreen:
    312         // return VK_SNAPSHOT; // (2C) PRINT SCREEN key
    313314    case Qt::Key_Insert:
    314315        return VK_INSERT; // (2D) INS key
Note: See TracChangeset for help on using the changeset viewer.