Changeset 67402 in webkit

Timestamp:

Sep 13, 2010 12:05:53 PM (14 years ago)

Author:

alex

Message:

2010-09-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Kenneth Rohde Christiansen.

[Gtk] Reduce the size of the shadow buffer in the paths using the clip region
​https://bugs.webkit.org/show_bug.cgi?id=44699

Intersect the clip bounding rect with the path that we are going
to use to create the shadow in order to reduce the region we have
to blur.

• platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cairo/GraphicsContextCairo.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-09-13  Alejandro G. Castro  <alex@igalia.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Gtk] Reduce the size of the shadow buffer in the paths using the clip region
+        https://bugs.webkit.org/show_bug.cgi?id=44699
+
+        Intersect the clip bounding rect with the path that we are going
+        to use to create the shadow in order to reduce the region we have
+        to blur.
+
+        * platform/graphics/cairo/GraphicsContextCairo.cpp:
+        (WebCore::drawPathShadow):
+
 210-09-13  Darin Fisher  <darin@chromium.org>
 

trunk/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp

@@ -215 +215 @@
     GraphicsContext::calculateShadowBufferDimensions(shadowBufferSize, shadowRect, radius, rect, shadowOffset, shadowBlur);
 
+    cairo_clip_extents(cr, &x0, &y0, &x1, &y1);
+    FloatRect clipRect(x0, y0, x1 - x0, y1 - y0);
+
+    FloatPoint rectLocation = shadowRect.location();
+
+    // Reduce the shadow rect using the clip area.
+    if (!clipRect.contains(shadowRect)) {
+        shadowRect.intersect(clipRect);
+        if (shadowRect.isEmpty())
+            return;
+        shadowRect.inflate(radius);
+        shadowBufferSize = IntSize(shadowRect.width(), shadowRect.height());
+    }
+
+    shadowOffset = rectLocation - shadowRect.location();
+
     // Create suitably-sized ImageBuffer to hold the shadow.
     OwnPtr<ImageBuffer> shadowBuffer = ImageBuffer::create(shadowBufferSize);
@@ -221 +237 @@
     cairo_t* shadowContext = shadowBuffer->context()->platformContext();
     copyContextProperties(cr, shadowContext);
-    cairo_translate(shadowContext, -rect.x() + radius, -rect.y() + radius);
+    cairo_translate(shadowContext, -rect.x() + radius + shadowOffset.width(), -rect.y() + radius + shadowOffset.height());
     cairo_new_path(shadowContext);
     OwnPtr<cairo_path_t> path(cairo_copy_path(cr));