Changeset 67463 in webkit


Ignore:
Timestamp:
Sep 14, 2010 6:25:06 AM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-09-14 Pierre-Antoine LaFayette <plafayet@codeaurora.org>

Reviewed by Darin Adler.

REGRESSION (r52839): Incomplete repaint of IMG with text-align:center
https://bugs.webkit.org/show_bug.cgi?id=40142

Add pixel tests to verify proper repaint of RenderReplaced as well as non-inline children.

  • fast/repaint/block-layout-inline-children-float-positioned.html: Added.
  • fast/repaint/block-layout-inline-children-replaced.html: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.checksum: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.

2010-09-14 Pierre-Antoine LaFayette <plafayet@codeaurora.org>

Reviewed by Darin Adler.

REGRESSION (r52839): Incomplete repaint of IMG with text-align:center
https://bugs.webkit.org/show_bug.cgi?id=40142

http://trac.webkit.org/changeset/52839 didn't really deal with the inline replaced element case. This just generalizes to all inline content.

Patch by: Dave Hyatt

Tests: fast/repaint/block-layout-inline-children-float-positioned.html

fast/repaint/block-layout-inline-children-replaced.html

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
Location:
trunk
Files:
8 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r67460 r67463  
     12010-09-14  Pierre-Antoine LaFayette  <plafayet@codeaurora.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        REGRESSION (r52839): Incomplete repaint of IMG with text-align:center
     6        https://bugs.webkit.org/show_bug.cgi?id=40142
     7
     8        Add pixel tests to verify proper repaint of RenderReplaced as well as non-inline children.
     9
     10        * fast/repaint/block-layout-inline-children-float-positioned.html: Added.
     11        * fast/repaint/block-layout-inline-children-replaced.html: Added.
     12        * platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.checksum: Added.
     13        * platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
     14        * platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
     15        * platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
     16        * platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
     17        * platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
     18
    1192010-09-14  Pavel Podivilov  <podivilov@chromium.org>
    220
  • trunk/WebCore/ChangeLog

    r67461 r67463  
     12010-09-14  Pierre-Antoine LaFayette  <plafayet@codeaurora.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        REGRESSION (r52839): Incomplete repaint of IMG with text-align:center
     6        https://bugs.webkit.org/show_bug.cgi?id=40142
     7
     8        http://trac.webkit.org/changeset/52839 didn't really deal with the inline replaced element case.  This just generalizes to all inline content.
     9
     10        Patch by: Dave Hyatt
     11
     12        Tests: fast/repaint/block-layout-inline-children-float-positioned.html
     13               fast/repaint/block-layout-inline-children-replaced.html
     14
     15        * rendering/RenderBlockLineLayout.cpp:
     16        (WebCore::RenderBlock::layoutInlineChildren):
     17         
    1182010-09-14  Balazs Kelemen  <kb@inf.u-szeged.hu>
    219
  • trunk/WebCore/rendering/RenderBlockLineLayout.cpp

    r67350 r67463  
    560560        bool hasInlineChild = false;
    561561        while (o) {
     562            if (!hasInlineChild && o->isInline())
     563                hasInlineChild = true;
     564
    562565            if (o->isReplaced() || o->isFloating() || o->isPositioned()) {
    563566                RenderBox* box = toRenderBox(o);
     
    581584                }
    582585            } else if (o->isText() || (o->isRenderInline() && !endOfInline)) {
    583                 hasInlineChild = true;
    584586                if (fullLayout || o->selfNeedsLayout())
    585587                    dirtyLineBoxesForRenderer(o, fullLayout);
Note: See TracChangeset for help on using the changeset viewer.