Changeset 67513 in webkit

Timestamp:

Sep 14, 2010 4:29:38 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

document.lastModified gives no output if the response doesn't have a Last-Modified header
​https://bugs.webkit.org/show_bug.cgi?id=8475

Implement document.lastModified as per HTML5.

Tests: http/tests/misc/last-modified-parsing.html

http/tests/misc/no-last-modified.html

• dom/Document.cpp: (WebCore::Document::lastModified):

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

document.lastModified gives no output if the response doesn't have a Last-Modified header
​https://bugs.webkit.org/show_bug.cgi?id=8475

• http/tests/misc/last-modified-parsing-expected.txt: Added.
• http/tests/misc/last-modified-parsing.html: Added.
  • Tests some details of our date parsing and serialization. The serialization format is kind of goofy, but that's what the spec seems to want.
• http/tests/misc/no-last-modified-expected.txt: Added.
• http/tests/misc/no-last-modified.html: Added.
  • Test was happens if the server doesn't send a Last-Modified header. We're supposed to use the current date and time.
• http/tests/resources/last-modified.php: Added.
  • PHP helper script.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/misc/last-modified-parsing-expected.txt (added)
• LayoutTests/http/tests/misc/last-modified-parsing.html (added)
• LayoutTests/http/tests/misc/no-last-modified-expected.txt (added)
• LayoutTests/http/tests/misc/no-last-modified.html (added)
• LayoutTests/http/tests/resources/last-modified.php (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/Document.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-09-14  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        document.lastModified gives no output if the response doesn't have a Last-Modified header
+        https://bugs.webkit.org/show_bug.cgi?id=8475
+
+        * http/tests/misc/last-modified-parsing-expected.txt: Added.
+        * http/tests/misc/last-modified-parsing.html: Added.
+            - Tests some details of our date parsing and serialization.  The
+              serialization format is kind of goofy, but that's what the spec
+              seems to want.
+        * http/tests/misc/no-last-modified-expected.txt: Added.
+        * http/tests/misc/no-last-modified.html: Added.
+            - Test was happens if the server doesn't send a Last-Modified
+              header.  We're supposed to use the current date and time.
+        * http/tests/resources/last-modified.php: Added.
+            - PHP helper script.
+
 2010-09-14  Adam Barth  <abarth@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-09-14  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        document.lastModified gives no output if the response doesn't have a Last-Modified header
+        https://bugs.webkit.org/show_bug.cgi?id=8475
+
+        Implement document.lastModified as per HTML5.
+
+        Tests: http/tests/misc/last-modified-parsing.html
+               http/tests/misc/no-last-modified.html
+
+        * dom/Document.cpp:
+        (WebCore::Document::lastModified):
+
 2010-09-14  Adam Barth  <abarth@webkit.org>
 

trunk/WebCore/dom/Document.cpp

@@ -44 +44 @@
 #include "CookieJar.h"
 #include "CustomEvent.h"
+#include "DateComponents.h"
 #include "DOMImplementation.h"
 #include "DOMWindow.h"
@@ -3612 +3613 @@
 }
 
+// http://www.whatwg.org/specs/web-apps/current-work/#dom-document-lastmodified
 String Document::lastModified() const
 {
-    Frame* f = frame();
-    if (!f)
-        return String();
-    DocumentLoader* loader = f->loader()->documentLoader();
-    if (!loader)
-        return String();
-    return loader->response().httpHeaderField("Last-Modified");
+    DateComponents date;
+    bool foundDate = false;
+    if (m_frame) {
+        String httpLastModified = m_frame->loader()->documentLoader()->response().httpHeaderField("Last-Modified");
+        if (!httpLastModified.isEmpty()) {
+            date.setMillisecondsSinceEpochForDateTime(parseDate(httpLastModified));
+            foundDate = true;
+        }
+    }
+    // FIXME: If this document came from the file system, the HTML5
+    // specificiation tells us to read the last modification date from the file
+    // system.
+    if (!foundDate)
+        date.setMillisecondsSinceEpochForDateTime(currentTimeMS());
+    return String::format("%02d/%02d/%04d %02d:%02d:%02d", date.month() + 1, date.monthDay(), date.fullYear(), date.hour(), date.minute(), date.second());
 }