Changeset 67687 in webkit

Timestamp:

Sep 16, 2010 6:32:42 PM (14 years ago)

Author:

tonikitoo@webkit.org

Message:

2010-09-12 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.

We usually separate methods whose body are larger the a few lines from the class definition.

• QtTestBrowser/webview.h: (WebViewGraphicsBased::yRotation): (WebViewGraphicsBased::setYRotation):

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• QtTestBrowser/webview.h (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
+
+        Reviewed by Andreas Kling.
+
+        Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
+
+        We usually separate methods whose body are larger than a few lines from the class definition.
+
+        * QtTestBrowser/webview.h:
+        (WebViewGraphicsBased::yRotation):
+        (WebViewGraphicsBased::setYRotation):
+
 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
 

trunk/WebKitTools/QtTestBrowser/webview.h

@@ -88 +88 @@
     bool resizesToContents() const { return m_resizesToContents; }
 
-    void setYRotation(qreal angle)
-    {
-#if QT_VERSION >= QT_VERSION_CHECK(4, 6, 0)
-        QRectF r = m_item->boundingRect();
-        m_item->setTransform(QTransform()
-            .translate(r.width() / 2, r.height() / 2)
-            .rotate(angle, Qt::YAxis)
-            .translate(-r.width() / 2, -r.height() / 2));
-#endif
-        m_yRotation = angle;
-    }
-    qreal yRotation() const
-    {
-        return m_yRotation;
-    }
+    void setYRotation(qreal angle);
+    qreal yRotation() const { return m_yRotation; }
 
     GraphicsWebView* graphicsWebView() const { return m_item; }
@@ -129 +116 @@
 };
 
+inline void WebViewGraphicsBased::setYRotation(qreal angle)
+{
+#if QT_VERSION >= QT_VERSION_CHECK(4, 6, 0)
+    QRectF r = graphicsWebView()->boundingRect();
+    graphicsWebView()->setTransform(QTransform()
+        .translate(r.width() / 2, r.height() / 2)
+        .rotate(angle, Qt::YAxis)
+        .translate(-r.width() / 2, -r.height() / 2));
 #endif
+    m_yRotation = angle;
+}
+
+#endif