Changeset 67758 in webkit


Ignore:
Timestamp:
Sep 17, 2010 4:23:17 PM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-09-17 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
​https://bugs.webkit.org/show_bug.cgi?id=45362

Reduced the minimum allowed DOMTimer interval to 4ms. This has us matching Chrome,
which hasn't had any problem with 4ms in the past 2 years, as well as increasing our
performance on perf tests that have tight frequent loops such as canvas "animation"
performance tests.

No new tests added. Can't reliably instrument a test in javascript to verify that
the minimum clamped interval time is in fact 4ms.

  • WebCore.exp.in:
  • page/DOMTimer.cpp: Removed old comments.
  • page/DOMTimer.h: Removed old comments.
  • page/Settings.cpp: Exposted new method to set minimum DOMTimer interval.
  • page/Settings.h:

2010-09-17 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
​https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.

2010-09-17 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
​https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebView.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.

2010-09-17 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
​https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebProcess/WebPage/WebPage.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
Location:
trunk
Files:
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r67751 r67758  
     12010-09-17  Matthew Delaney  <mdelaney@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Reduce minimum DOMTimer interval
     6        https://bugs.webkit.org/show_bug.cgi?id=45362
     7
     8        Reduced the minimum allowed DOMTimer interval to 4ms. This has us matching Chrome,
     9        which hasn't had any problem with 4ms in the past 2 years, as well as increasing our
     10        performance on perf tests that have tight frequent loops such as canvas "animation"
     11        performance tests.
     12
     13        No new tests added. Can't reliably instrument a test in javascript to verify that
     14        the minimum clamped interval time is in fact 4ms.
     15
     16        * WebCore.exp.in:
     17        * page/DOMTimer.cpp: Removed old comments.
     18        * page/DOMTimer.h: Removed old comments.
     19        * page/Settings.cpp: Exposted new method to set minimum DOMTimer interval.
     20        * page/Settings.h:
     21
    1222010-09-17  Marc-Antoine Ruel  <maruel@chromium.org>
    223

  • trunk/WebCore/WebCore.exp.in

    r67731 r67758  
    702702__ZN7WebCore8Settings21setWebSecurityEnabledEb
    703703__ZN7WebCore8Settings22setLocalStorageEnabledEb
     704__ZN7WebCore8Settings22setMinDOMTimerIntervalEd
    704705__ZN7WebCore8Settings22setSansSerifFontFamilyERKN3WTF12AtomicStringE
    705706__ZN7WebCore8Settings22setSessionStorageQuotaEj

  • trunk/WebCore/page/DOMTimer.cpp

    r62551 r67758  
    6161    double intervalMilliseconds = max(oneMillisecond, timeout * oneMillisecond);
    6262
    63     // Use a minimum interval of 10 ms to match other browsers, but only once we've
    64     // nested enough to notice that we're repeating.
    65     // Faster timers might be "better", but they're incompatible.
    6663    if (intervalMilliseconds < s_minTimerInterval && m_nestingLevel >= maxTimerNestingLevel)
    6764        intervalMilliseconds = s_minTimerInterval;

  • trunk/WebCore/page/DOMTimer.h

    r60150 r67758  
    5050
    5151        // The lowest allowable timer setting (in seconds, 0.001 == 1 ms).
    52         // Default is 10ms.
    53         // Chromium uses a non-default timeout.
    5452        static double minTimerInterval() { return s_minTimerInterval; }
    5553        static void setMinTimerInterval(double value) { s_minTimerInterval = value; }

  • trunk/WebCore/page/Settings.cpp

    r67274 r67758  
    2828
    2929#include "BackForwardList.h"
     30#include "CachedResourceLoader.h"
     31#include "DOMTimer.h"
    3032#include "Database.h"
    31 #include "CachedResourceLoader.h"
    3233#include "Frame.h"
    3334#include "FrameTree.h"
    … …  
    405406}
    406407
     408void Settings::setMinDOMTimerInterval(double interval)
     409{
     410    DOMTimer::setMinTimerInterval(interval);
     411}
     412
    407413void Settings::setUsesPageCache(bool usesPageCache)
    408414{

  • trunk/WebCore/page/Settings.h

    r67274 r67758  
    200200        void setDOMPasteAllowed(bool);
    201201        bool isDOMPasteAllowed() const { return m_isDOMPasteAllowed; }
     202       
     203        void setMinDOMTimerInterval(double); // Interval specified in seconds.
    202204       
    203205        void setUsesPageCache(bool);

  • trunk/WebKit/mac/ChangeLog

    r67731 r67758  
     12010-09-17  Matthew Delaney  <mdelaney@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Reduce minimum DOMTimer interval
     6        https://bugs.webkit.org/show_bug.cgi?id=45362
     7
     8        * WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.
     9
    1102010-09-17  Chris Marrin  <cmarrin@apple.com>
    211

  • trunk/WebKit/mac/WebView/WebView.mm

    r67731 r67758  
    697697    _private->page->setCanStartMedia([self window]);
    698698    _private->page->settings()->setLocalStorageDatabasePath([[self preferences] _localStorageDatabasePath]);
     699    _private->page->settings()->setMinDOMTimerInterval(0.004);
    699700
    700701    [WebFrame _createMainFrameWithPage:_private->page frameName:frameName frameView:frameView];

  • trunk/WebKit/win/ChangeLog

    r67735 r67758  
     12010-09-17  Matthew Delaney  <mdelaney@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Reduce minimum DOMTimer interval
     6        https://bugs.webkit.org/show_bug.cgi?id=45362
     7
     8        * WebView.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
     9
    1102010-09-17  Simon Fraser  <simon.fraser@apple.com>
    211

  • trunk/WebKit/win/WebView.cpp

    r67735 r67758  
    25682568    WebKitSetApplicationCachePathIfNecessary();
    25692569    WebPlatformStrategies::initialize();
    2570    
     2570
    25712571#if USE(SAFARI_THEME)
    25722572    BOOL shouldPaintNativeControls;
    … …  
    25902590#endif
    25912591    m_page = new Page(pageClients);
     2592    m_page->settings()->setMinDOMTimerInterval(0.004);
    25922593
    25932594    BSTR localStoragePath;

  • trunk/WebKit2/ChangeLog

    r67754 r67758  
     12010-09-17  Matthew Delaney  <mdelaney@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Reduce minimum DOMTimer interval
     6        https://bugs.webkit.org/show_bug.cgi?id=45362
     7
     8        * WebProcess/WebPage/WebPage.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
     9
    1102010-09-17  Anders Carlsson  <andersca@apple.com>
    211

  • trunk/WebKit2/WebProcess/WebPage/WebPage.cpp

    r67631 r67758  
    117117    m_page->settings()->setSerifFontFamily(store.serifFontFamily);
    118118    m_page->settings()->setJavaScriptCanOpenWindowsAutomatically(true);
     119    m_page->settings()->setMinDOMTimerInterval(0.004);
    119120
    120121    m_page->setGroupName("WebKit2Group");
Note: See TracChangeset for help on using the changeset viewer.