Changeset 67953 in webkit

Timestamp:

Sep 21, 2010 7:35:48 AM (14 years ago)

Author:

Patrick Gansterer

Message:

2010-09-21 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Use WTF::Vector for storing formData in ResourceHandleWin.
​https://bugs.webkit.org/show_bug.cgi?id=46180

• platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
• platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestComplete):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/ResourceHandleInternal.h (modified) (2 diffs)
• platform/network/win/ResourceHandleWin.cpp (modified) (3 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-09-21  Patrick Gansterer  <paroga@webkit.org>
+
+        Reviewed by Adam Roben.
+
+        Use WTF::Vector for storing formData in ResourceHandleWin.
+        https://bugs.webkit.org/show_bug.cgi?id=46180
+
+        * platform/network/ResourceHandleInternal.h:
+        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
+        * platform/network/win/ResourceHandleWin.cpp:
+        (WebCore::ResourceHandle::onHandleCreated):
+        (WebCore::ResourceHandle::onRequestComplete):
+
 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
 

trunk/WebCore/platform/network/ResourceHandleInternal.h

@@ -97 +97 @@
             , m_jobId(0)
             , m_threadId(0)
-            , m_writing(false)
-            , m_formDataString(0)
-            , m_formDataLength(0)
+            , m_sentEndRequest(false)
             , m_bytesRemainingToWrite(0)
             , m_hasReceivedResponse(false)
@@ -172 +170 @@
         unsigned m_jobId;
         DWORD m_threadId;
-        bool m_writing;
-        char* m_formDataString;
-        int m_formDataLength;
+        bool m_sentEndRequest;
+        Vector<char> m_formData;
         int m_bytesRemainingToWrite;
         String m_postReferrer;

trunk/WebCore/platform/network/win/ResourceHandleWin.cpp

@@ -236 +236 @@
         headers += "\n";
         const CString& headersLatin1 = headers.latin1();
-        String formData = request().httpBody()->flattenToString();
+        if (firstRequest().httpBody()) {
+            firstRequest().httpBody()->flatten(d->m_formData);
+            d->m_bytesRemainingToWrite = d->m_formData.size();
+        }
         INTERNET_BUFFERSA buffers;
         memset(&buffers, 0, sizeof(buffers));
@@ -242 +245 @@
         buffers.lpcszHeader = headersLatin1.data();
         buffers.dwHeadersLength = headers.length();
-        buffers.dwBufferTotal = formData.length();
+        buffers.dwBufferTotal = d->m_bytesRemainingToWrite;
         
-        d->m_bytesRemainingToWrite = formData.length();
-        d->m_formDataString = (char*)malloc(formData.length());
-        d->m_formDataLength = formData.length();
-        strncpy(d->m_formDataString, formData.latin1().data(), formData.length());
-        d->m_writing = true;
         HttpSendRequestExA(d->m_secondaryHandle, &buffers, 0, 0, (DWORD_PTR)d->m_jobId);
         // FIXME: add proper error handling
@@ -267 +265 @@
 void ResourceHandle::onRequestComplete(LPARAM lParam)
 {
-    if (d->m_writing) {
+    if (d->m_bytesRemainingToWrite) {
         DWORD bytesWritten;
-        InternetWriteFile(d->m_secondaryHandle,
-                          d->m_formDataString + (d->m_formDataLength - d->m_bytesRemainingToWrite),
+        InternetWriteFile(d->m_requestHandle,
+                          d->m_formData.data() + (d->m_formData.size() - d->m_bytesRemainingToWrite),
                           d->m_bytesRemainingToWrite,
                           &bytesWritten);
         d->m_bytesRemainingToWrite -= bytesWritten;
-        if (!d->m_bytesRemainingToWrite) {
-            // End the request.
-            d->m_writing = false;
-            HttpEndRequest(d->m_secondaryHandle, 0, 0, (DWORD_PTR)d->m_jobId);
-            free(d->m_formDataString);
-            d->m_formDataString = 0;
-        }
+        if (d->m_bytesRemainingToWrite)
+            return;
+        d->m_formData.clear();
+    }
+
+    if (!d->m_sentEndRequest) {
+        HttpEndRequestW(d->m_requestHandle, 0, 0, reinterpret_cast<DWORD_PTR>(this));
+        d->m_sentEndRequest = true;
         return;
     }