Changeset 68105 in webkit


Ignore:
Timestamp:
Sep 22, 2010 5:58:53 PM (14 years ago)
Author:
kinuko@chromium.org
Message:

2010-09-22 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

[FileSystem] Fix Flags handling in DirectoryEntry custom binding code
​https://bugs.webkit.org/show_bug.cgi?id=46028

Do not use adoptRef to get RefPtr from a raw pointer that is already
adopted in toNative/toJS.

Test: fast/filesystem/flags-passing.html

  • bindings/js/JSDirectoryEntryCustom.cpp: (WebCore::JSDirectoryEntry::getFile): (WebCore::JSDirectoryEntry::getDirectory):
  • bindings/v8/custom/V8DirectoryEntryCustom.cpp: (WebCore::V8DirectoryEntry::getDirectoryCallback): (WebCore::V8DirectoryEntry::getFileCallback):

2010-09-22 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

[FileSystem] Fix Flags handling in DirectoryEntry custom binding code
​https://bugs.webkit.org/show_bug.cgi?id=46028

  • fast/filesystem/flags-passing-expected.txt: Added.
  • fast/filesystem/flags-passing.html: Added.
  • fast/filesystem/script-tests/TEMPLATE.html: Added.
  • fast/filesystem/script-tests/flags-passing.js: Added.
  • platform/gtk/Skipped: FileSystem API not supported on gtk.
  • platform/mac/Skipped: FileSystem API not supported on mac.
  • platform/qt/Skipped: FileSystem API not supported on qt.
  • platform/win/Skipped: FileSystem API not supported on win.
Location:
trunk
Files:
6 added
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r68104 r68105  
     12010-09-22  Kinuko Yasuda  <kinuko@chromium.org>
     2
     3        Reviewed by Dumitru Daniliuc.
     4
     5        [FileSystem] Fix Flags handling in DirectoryEntry custom binding code
     6        https://bugs.webkit.org/show_bug.cgi?id=46028
     7
     8        * fast/filesystem/flags-passing-expected.txt: Added.
     9        * fast/filesystem/flags-passing.html: Added.
     10        * fast/filesystem/script-tests/TEMPLATE.html: Added.
     11        * fast/filesystem/script-tests/flags-passing.js: Added.
     12        * platform/gtk/Skipped: FileSystem API not supported on gtk.
     13        * platform/mac/Skipped: FileSystem API not supported on mac.
     14        * platform/qt/Skipped: FileSystem API not supported on qt.
     15        * platform/win/Skipped: FileSystem API not supported on win.
     16
    1172010-09-22  Tony Chang  <tony@chromium.org>
    218

  • trunk/LayoutTests/platform/gtk/Skipped

    r67932 r68105  
    59305930# https://bugs.webkit.org/show_bug.cgi?id=46169
    59315931media/video-controls-with-mutation-event-handler.html
     5932
     5933# FileSystem API is not supported.
     5934fast/filesystem

  • trunk/LayoutTests/platform/mac/Skipped

    r67928 r68105  
    315315# see also https://bugs.webkit.org/show_bug.cgi?id=45021
    316316media/context-menu-actions.html
     317
     318# FileSystem API is not supported.
     319fast/filesystem

  • trunk/LayoutTests/platform/qt/Skipped

    r67928 r68105  
    54825482fast/parser/pre-html5-parser-quirks.html
    54835483
     5484# FileSystem API is not supported.
     5485fast/filesystem

  • trunk/LayoutTests/platform/win/Skipped

    r67928 r68105  
    10051005fast/parser/pre-html5-parser-quirks.html
    10061006
     1007# FileSystem API is not supported.
     1008fast/filesystem

  • trunk/WebCore/ChangeLog

    r68103 r68105  
     12010-09-22  Kinuko Yasuda  <kinuko@chromium.org>
     2
     3        Reviewed by Dumitru Daniliuc.
     4
     5        [FileSystem] Fix Flags handling in DirectoryEntry custom binding code
     6        https://bugs.webkit.org/show_bug.cgi?id=46028
     7
     8        Do not use adoptRef to get RefPtr from a raw pointer that is already
     9        adopted in toNative/toJS.
     10
     11        Test: fast/filesystem/flags-passing.html
     12
     13        * bindings/js/JSDirectoryEntryCustom.cpp:
     14        (WebCore::JSDirectoryEntry::getFile):
     15        (WebCore::JSDirectoryEntry::getDirectory):
     16        * bindings/v8/custom/V8DirectoryEntryCustom.cpp:
     17        (WebCore::V8DirectoryEntry::getDirectoryCallback):
     18        (WebCore::V8DirectoryEntry::getFileCallback):
     19
    1202010-09-22  Jia Pu  <jpu@apple.com>
    221

  • trunk/WebCore/bindings/js/JSDirectoryEntryCustom.cpp

    r67538 r68105  
    6767        flags->setExclusive(jsExclusive.toBoolean(exec));
    6868    } else
    69         flags = adoptRef(toFlags(exec->argument(1)));
     69        flags = toFlags(exec->argument(1));
    7070    if (exec->hadException())
    7171        return jsUndefined();
    … …  
    113113        flags->setExclusive(jsExclusive.toBoolean(exec));
    114114    } else
    115         flags = adoptRef(toFlags(exec->argument(1)));
     115        flags = toFlags(exec->argument(1));
    116116    if (exec->hadException())
    117117        return jsUndefined();

  • trunk/WebCore/bindings/v8/custom/V8DirectoryEntryCustom.cpp

    r67538 r68105  
    7272    } else {
    7373       EXCEPTION_BLOCK(Flags*, tmp_flags, V8Flags::HasInstance(args[1]) ? V8Flags::toNative(v8::Handle<v8::Object>::Cast(args[1])) : 0);
    74        flags = adoptRef(tmp_flags);
     74       flags = tmp_flags;
    7575    }
    7676    RefPtr<EntryCallback> successCallback;
    … …  
    115115    } else {
    116116       EXCEPTION_BLOCK(Flags*, tmp_flags, V8Flags::HasInstance(args[1]) ? V8Flags::toNative(v8::Handle<v8::Object>::Cast(args[1])) : 0);
    117        flags = adoptRef(tmp_flags);
     117       flags = tmp_flags;
    118118    }
    119119    RefPtr<EntryCallback> successCallback;
Note: See TracChangeset for help on using the changeset viewer.