Changeset 68105 in webkit
- Timestamp:
- Sep 22, 2010 5:58:53 PM (14 years ago)
- Location:
- trunk
- Files:
-
- 6 added
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r68104 r68105 1 2010-09-22 Kinuko Yasuda <kinuko@chromium.org> 2 3 Reviewed by Dumitru Daniliuc. 4 5 [FileSystem] Fix Flags handling in DirectoryEntry custom binding code 6 https://bugs.webkit.org/show_bug.cgi?id=46028 7 8 * fast/filesystem/flags-passing-expected.txt: Added. 9 * fast/filesystem/flags-passing.html: Added. 10 * fast/filesystem/script-tests/TEMPLATE.html: Added. 11 * fast/filesystem/script-tests/flags-passing.js: Added. 12 * platform/gtk/Skipped: FileSystem API not supported on gtk. 13 * platform/mac/Skipped: FileSystem API not supported on mac. 14 * platform/qt/Skipped: FileSystem API not supported on qt. 15 * platform/win/Skipped: FileSystem API not supported on win. 16 1 17 2010-09-22 Tony Chang <tony@chromium.org> 2 18 -
trunk/LayoutTests/platform/gtk/Skipped
r67932 r68105 5930 5930 # https://bugs.webkit.org/show_bug.cgi?id=46169 5931 5931 media/video-controls-with-mutation-event-handler.html 5932 5933 # FileSystem API is not supported. 5934 fast/filesystem -
trunk/LayoutTests/platform/mac/Skipped
r67928 r68105 315 315 # see also https://bugs.webkit.org/show_bug.cgi?id=45021 316 316 media/context-menu-actions.html 317 318 # FileSystem API is not supported. 319 fast/filesystem -
trunk/LayoutTests/platform/qt/Skipped
r67928 r68105 5482 5482 fast/parser/pre-html5-parser-quirks.html 5483 5483 5484 # FileSystem API is not supported. 5485 fast/filesystem -
trunk/LayoutTests/platform/win/Skipped
r67928 r68105 1005 1005 fast/parser/pre-html5-parser-quirks.html 1006 1006 1007 # FileSystem API is not supported. 1008 fast/filesystem -
trunk/WebCore/ChangeLog
r68103 r68105 1 2010-09-22 Kinuko Yasuda <kinuko@chromium.org> 2 3 Reviewed by Dumitru Daniliuc. 4 5 [FileSystem] Fix Flags handling in DirectoryEntry custom binding code 6 https://bugs.webkit.org/show_bug.cgi?id=46028 7 8 Do not use adoptRef to get RefPtr from a raw pointer that is already 9 adopted in toNative/toJS. 10 11 Test: fast/filesystem/flags-passing.html 12 13 * bindings/js/JSDirectoryEntryCustom.cpp: 14 (WebCore::JSDirectoryEntry::getFile): 15 (WebCore::JSDirectoryEntry::getDirectory): 16 * bindings/v8/custom/V8DirectoryEntryCustom.cpp: 17 (WebCore::V8DirectoryEntry::getDirectoryCallback): 18 (WebCore::V8DirectoryEntry::getFileCallback): 19 1 20 2010-09-22 Jia Pu <jpu@apple.com> 2 21 -
trunk/WebCore/bindings/js/JSDirectoryEntryCustom.cpp
r67538 r68105 67 67 flags->setExclusive(jsExclusive.toBoolean(exec)); 68 68 } else 69 flags = adoptRef(toFlags(exec->argument(1)));69 flags = toFlags(exec->argument(1)); 70 70 if (exec->hadException()) 71 71 return jsUndefined(); … … 113 113 flags->setExclusive(jsExclusive.toBoolean(exec)); 114 114 } else 115 flags = adoptRef(toFlags(exec->argument(1)));115 flags = toFlags(exec->argument(1)); 116 116 if (exec->hadException()) 117 117 return jsUndefined(); -
trunk/WebCore/bindings/v8/custom/V8DirectoryEntryCustom.cpp
r67538 r68105 72 72 } else { 73 73 EXCEPTION_BLOCK(Flags*, tmp_flags, V8Flags::HasInstance(args[1]) ? V8Flags::toNative(v8::Handle<v8::Object>::Cast(args[1])) : 0); 74 flags = adoptRef(tmp_flags);74 flags = tmp_flags; 75 75 } 76 76 RefPtr<EntryCallback> successCallback; … … 115 115 } else { 116 116 EXCEPTION_BLOCK(Flags*, tmp_flags, V8Flags::HasInstance(args[1]) ? V8Flags::toNative(v8::Handle<v8::Object>::Cast(args[1])) : 0); 117 flags = adoptRef(tmp_flags);117 flags = tmp_flags; 118 118 } 119 119 RefPtr<EntryCallback> successCallback;
Note: See TracChangeset
for help on using the changeset viewer.