Changeset 68180 in webkit


Ignore:
Timestamp:
Sep 23, 2010 12:33:39 PM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-09-23 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Rename FileWriterClient to AsyncFileWriterClient.
https://bugs.webkit.org/show_bug.cgi?id=46325

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/AsyncFileWriter.h:
  • fileapi/AsyncFileWriterClient.h: Copied from WebCore/fileapi/FileWriterClient.h.
  • fileapi/FileWriter.h:
  • fileapi/FileWriterClient.h: Removed.
  • platform/AsyncFileSystem.h:

2010-09-23 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Rename FileWriterClient to AsyncFileWriterClient.
https://bugs.webkit.org/show_bug.cgi?id=46325

  • src/AsyncFileSystemChromium.cpp:
  • src/AsyncFileSystemChromium.h:
  • src/AsyncFileWriterChromium.cpp:
  • src/AsyncFileWriterChromium.h:
Location:
trunk
Files:
13 edited
1 moved

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r68177 r68180  
     12010-09-23  Eric Uhrhane  <ericu@chromium.org>
     2
     3        Reviewed by David Levin.
     4
     5        Rename FileWriterClient to AsyncFileWriterClient.
     6        https://bugs.webkit.org/show_bug.cgi?id=46325
     7
     8        * GNUmakefile.am:
     9        * WebCore.gypi:
     10        * WebCore.vcproj/WebCore.vcproj:
     11        * WebCore.xcodeproj/project.pbxproj:
     12        * fileapi/AsyncFileWriter.h:
     13        * fileapi/AsyncFileWriterClient.h: Copied from WebCore/fileapi/FileWriterClient.h.
     14        * fileapi/FileWriter.h:
     15        * fileapi/FileWriterClient.h: Removed.
     16        * platform/AsyncFileSystem.h:
     17
    1182010-09-23  David Hyatt  <hyatt@apple.com>
    219
  • trunk/WebCore/GNUmakefile.am

    r68145 r68180  
    13511351        WebCore/editing/WrapContentsInDummySpanCommand.h \
    13521352        WebCore/fileapi/AsyncFileWriter.h \
     1353        WebCore/fileapi/AsyncFileWriterClient.h \
    13531354        WebCore/fileapi/BlobBuilder.cpp \
    13541355        WebCore/fileapi/BlobBuilder.h \
     
    13941395        WebCore/fileapi/FileThreadTask.h \
    13951396        WebCore/fileapi/FileWriterCallback.h \
    1396         WebCore/fileapi/FileWriterClient.h \
    13971397        WebCore/fileapi/FileWriter.cpp \
    13981398        WebCore/fileapi/FileWriter.h \
  • trunk/WebCore/WebCore.gypi

    r68022 r68180  
    14391439            'editing/visible_units.h',
    14401440            'fileapi/AsyncFileWriter.h',
     1441            'fileapi/AsyncFileWriterClient.h',
    14411442            'fileapi/Blob.cpp',
    14421443            'fileapi/Blob.h',
     
    14841485            'fileapi/FileWriter.h',
    14851486            'fileapi/FileWriterCallback.h',
    1486             'fileapi/FileWriterClient.h',
    14871487            'fileapi/Flags.h',
    14881488            'fileapi/LocalFileSystem.h',
  • trunk/WebCore/WebCore.vcproj/WebCore.vcproj

    r68066 r68180  
    3752237522                        </File>
    3752337523                        <File
     37524                                RelativePath="..\fileapi\AsyncFileWriterClient.h"
     37525                                >
     37526                        </File>
     37527                        <File
    3752437528                                RelativePath="..\html\AsyncImageResizer.cpp"
    3752537529                                >
     
    3782337827                        <File
    3782437828                                RelativePath="..\fileapi\FileWriterCallback.h"
    37825                                 >
    37826                         </File>
    37827                         <File
    37828                                 RelativePath="..\fileapi\FileWriterClient.h"
    3782937829                                >
    3783037830                        </File>
  • trunk/WebCore/WebCore.xcodeproj/project.pbxproj

    r68022 r68180  
    27782778                973E325710883B7C005BC493 /* ResourceLoadNotifier.h in Headers */ = {isa = PBXBuildFile; fileRef = 973E325510883B7C005BC493 /* ResourceLoadNotifier.h */; settings = {ATTRIBUTES = (Private, ); }; };
    27792779                976D6C77122B8A3D001FD1F7 /* AsyncFileWriter.h in Headers */ = {isa = PBXBuildFile; fileRef = 976D6C58122B8A3D001FD1F7 /* AsyncFileWriter.h */; };
     2780                976D6C93122B8A3D001FD1F7 /* AsyncFileWriterClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 976D6C74122B8A3D001FD1F7 /* AsyncFileWriterClient.h */; };
    27802781                976D6C78122B8A3D001FD1F7 /* Blob.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 976D6C59122B8A3D001FD1F7 /* Blob.cpp */; };
    27812782                976D6C79122B8A3D001FD1F7 /* Blob.h in Headers */ = {isa = PBXBuildFile; fileRef = 976D6C5A122B8A3D001FD1F7 /* Blob.h */; };
     
    27982799                976D6C90122B8A3D001FD1F7 /* FileWriter.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 976D6C71122B8A3D001FD1F7 /* FileWriter.cpp */; };
    27992800                976D6C91122B8A3D001FD1F7 /* FileWriter.h in Headers */ = {isa = PBXBuildFile; fileRef = 976D6C72122B8A3D001FD1F7 /* FileWriter.h */; };
    2800                 976D6C93122B8A3D001FD1F7 /* FileWriterClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 976D6C74122B8A3D001FD1F7 /* FileWriterClient.h */; };
    28012801                976D6C94122B8A3D001FD1F7 /* ThreadableBlobRegistry.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 976D6C75122B8A3D001FD1F7 /* ThreadableBlobRegistry.cpp */; };
    28022802                976D6C95122B8A3D001FD1F7 /* ThreadableBlobRegistry.h in Headers */ = {isa = PBXBuildFile; fileRef = 976D6C76122B8A3D001FD1F7 /* ThreadableBlobRegistry.h */; };
     
    86788678                973E325510883B7C005BC493 /* ResourceLoadNotifier.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ResourceLoadNotifier.h; sourceTree = "<group>"; };
    86798679                976D6C58122B8A3D001FD1F7 /* AsyncFileWriter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = AsyncFileWriter.h; path = fileapi/AsyncFileWriter.h; sourceTree = "<group>"; };
     8680                976D6C74122B8A3D001FD1F7 /* AsyncFileWriterClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = AsyncFileWriterClient.h; path = fileapi/AsyncFileWriterClient.h; sourceTree = "<group>"; };
    86808681                976D6C59122B8A3D001FD1F7 /* Blob.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = Blob.cpp; path = fileapi/Blob.cpp; sourceTree = "<group>"; };
    86818682                976D6C5A122B8A3D001FD1F7 /* Blob.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Blob.h; path = fileapi/Blob.h; sourceTree = "<group>"; };
     
    86988699                976D6C71122B8A3D001FD1F7 /* FileWriter.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = FileWriter.cpp; path = fileapi/FileWriter.cpp; sourceTree = "<group>"; };
    86998700                976D6C72122B8A3D001FD1F7 /* FileWriter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = FileWriter.h; path = fileapi/FileWriter.h; sourceTree = "<group>"; };
    8700                 976D6C74122B8A3D001FD1F7 /* FileWriterClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = FileWriterClient.h; path = fileapi/FileWriterClient.h; sourceTree = "<group>"; };
    87018701                976D6C75122B8A3D001FD1F7 /* ThreadableBlobRegistry.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = ThreadableBlobRegistry.cpp; path = fileapi/ThreadableBlobRegistry.cpp; sourceTree = "<group>"; };
    87028702                976D6C76122B8A3D001FD1F7 /* ThreadableBlobRegistry.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = ThreadableBlobRegistry.h; path = fileapi/ThreadableBlobRegistry.h; sourceTree = "<group>"; };
     
    1443414434                        children = (
    1443514435                                976D6C58122B8A3D001FD1F7 /* AsyncFileWriter.h */,
     14436                                976D6C74122B8A3D001FD1F7 /* AsyncFileWriterClient.h */,
    1443614437                                976D6C59122B8A3D001FD1F7 /* Blob.cpp */,
    1443714438                                976D6C5A122B8A3D001FD1F7 /* Blob.h */,
     
    1447914480                                976D6C72122B8A3D001FD1F7 /* FileWriter.h */,
    1448014481                                893C47A61238908B002B3D86 /* FileWriterCallback.h */,
    14481                                 976D6C74122B8A3D001FD1F7 /* FileWriterClient.h */,
    1448214482                                8987854D122CA064003AABDA /* Flags.h */,
    1448314483                                8987854E122CA064003AABDA /* LocalFileSystem.cpp */,
     
    1787717877                                89D08DA112228451001241DF /* AsyncFileSystemCallbacks.h in Headers */,
    1787817878                                976D6C77122B8A3D001FD1F7 /* AsyncFileWriter.h in Headers */,
     17879                                976D6C93122B8A3D001FD1F7 /* AsyncFileWriterClient.h in Headers */,
    1787917880                                B0149E7E11A4B21500196A7B /* AsyncImageResizer.h in Headers */,
    1788017881                                8A413AE01207BBA50082016E /* AsyncScriptRunner.h in Headers */,
     
    1893218933                                976D6C91122B8A3D001FD1F7 /* FileWriter.h in Headers */,
    1893318934                                893C47A81238908B002B3D86 /* FileWriterCallback.h in Headers */,
    18934                                 976D6C93122B8A3D001FD1F7 /* FileWriterClient.h in Headers */,
    1893518935                                BC5EB69F0E81DAEB00B25965 /* FillLayer.h in Headers */,
    1893618936                                845E72F80FD261EE00A87D79 /* Filter.h in Headers */,
  • trunk/WebCore/fileapi/AsyncFileWriter.h

    r68101 r68180  
    4040
    4141class Blob;
    42 class FileWriterClient;
    4342
    4443class AsyncFileWriter {
  • trunk/WebCore/fileapi/AsyncFileWriterClient.h

    r68179 r68180  
    2929 */
    3030
    31 #ifndef FileWriterClient_h
    32 #define FileWriterClient_h
     31#ifndef AsyncFileWriterClient_h
     32#define AsyncFileWriterClient_h
    3333
    3434#if ENABLE(FILE_SYSTEM)
     
    3838namespace WebCore {
    3939
    40 class FileWriterClient {
     40class AsyncFileWriterClient {
    4141public:
    42     virtual ~FileWriterClient() {}
     42    virtual ~AsyncFileWriterClient() {}
    4343
    4444    virtual void didWrite(long long bytes, bool complete) = 0;
     
    5151#endif // ENABLE(FILE_SYSTEM)
    5252
    53 #endif // FileWriterClient_h
     53#endif // AsyncFileWriterClient_h
  • trunk/WebCore/fileapi/FileWriter.h

    r67622 r68180  
    3535
    3636#include "ActiveDOMObject.h"
     37#include "AsyncFileWriterClient.h"
    3738#include "EventTarget.h"
    38 #include "FileWriterClient.h"
    3939#include <wtf/OwnPtr.h>
    4040#include <wtf/PassOwnPtr.h>
     
    5050class ScriptExecutionContext;
    5151
    52 class FileWriter : public RefCounted<FileWriter>, public ActiveDOMObject, public EventTarget, public FileWriterClient {
     52class FileWriter : public RefCounted<FileWriter>, public ActiveDOMObject, public EventTarget, public AsyncFileWriterClient {
    5353public:
    5454    static PassRefPtr<FileWriter> create(ScriptExecutionContext* context)
     
    7575    long long length() const { return m_length; }
    7676
    77     // FileWriterClient
     77    // AsyncFileWriterClient
    7878    void didWrite(long long bytes, bool complete);
    7979    void didTruncate(long long length);
  • trunk/WebCore/platform/AsyncFileSystem.h

    r68101 r68180  
    4242class AsyncFileSystem;
    4343class AsyncFileSystemCallbacks;
    44 class FileWriterClient;
     44class AsyncFileWriterClient;
    4545
    4646// This class provides async interface for platform-specific file system implementation.  Note that all the methods take platform paths.
     
    112112    // AsyncFileSystemCallbacks::didCreateFileWriter() is called when an AsyncFileWriter is created successfully.
    113113    // AsyncFileSystemCallbacks::didFail() is called otherwise.
    114     virtual void createWriter(FileWriterClient* client, const String& path, PassOwnPtr<AsyncFileSystemCallbacks>) = 0;
     114    virtual void createWriter(AsyncFileWriterClient* client, const String& path, PassOwnPtr<AsyncFileSystemCallbacks>) = 0;
    115115
    116116    // Converts a given absolute virtual path to a platform path that starts with the platform root path of this file system.
  • trunk/WebKit/chromium/ChangeLog

    r68166 r68180  
     12010-09-23  Eric Uhrhane  <ericu@chromium.org>
     2
     3        Reviewed by David Levin.
     4
     5        Rename FileWriterClient to AsyncFileWriterClient.
     6        https://bugs.webkit.org/show_bug.cgi?id=46325
     7
     8        * src/AsyncFileSystemChromium.cpp:
     9        * src/AsyncFileSystemChromium.h:
     10        * src/AsyncFileWriterChromium.cpp:
     11        * src/AsyncFileWriterChromium.h:
     12
    1132010-09-23  Nate Chapin  <japhet@chromium.org>
    214
  • trunk/WebKit/chromium/src/AsyncFileSystemChromium.cpp

    r68101 r68180  
    104104class FileWriterHelperCallbacks : public WebKit::WebFileSystemCallbacks {
    105105public:
    106     FileWriterHelperCallbacks(FileWriterClient* client, const String& path, WebKit::WebFileSystem* webFileSystem, PassOwnPtr<WebCore::AsyncFileSystemCallbacks> callbacks)
     106    FileWriterHelperCallbacks(AsyncFileWriterClient* client, const String& path, WebKit::WebFileSystem* webFileSystem, PassOwnPtr<WebCore::AsyncFileSystemCallbacks> callbacks)
    107107        : m_client(client)
    108108        , m_path(path)
     
    150150
    151151private:
    152     FileWriterClient* m_client;
     152    AsyncFileWriterClient* m_client;
    153153    String m_path;
    154154    WebKit::WebFileSystem* m_webFileSystem;
     
    156156};
    157157
    158 void AsyncFileSystemChromium::createWriter(FileWriterClient* client, const String& path, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)
     158void AsyncFileSystemChromium::createWriter(AsyncFileWriterClient* client, const String& path, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)
    159159{
    160160    m_webFileSystem->readMetadata(path, new FileWriterHelperCallbacks(client, path, m_webFileSystem, callbacks));
  • trunk/WebKit/chromium/src/AsyncFileSystemChromium.h

    r68101 r68180  
    5959    virtual void directoryExists(const String& path, PassOwnPtr<AsyncFileSystemCallbacks>);
    6060    virtual void readDirectory(const String& path, PassOwnPtr<AsyncFileSystemCallbacks>);
    61     virtual void createWriter(FileWriterClient* client, const String& path, PassOwnPtr<AsyncFileSystemCallbacks>);
     61    virtual void createWriter(AsyncFileWriterClient* client, const String& path, PassOwnPtr<AsyncFileSystemCallbacks>);
    6262
    6363private:
  • trunk/WebKit/chromium/src/AsyncFileWriterChromium.cpp

    r68101 r68180  
    3434#if ENABLE(FILE_SYSTEM)
    3535
     36#include "AsyncFileWriterClient.h"
    3637#include "Blob.h"
    37 #include "FileWriterClient.h"
    3838#include "WebFileWriter.h"
    3939#include "WebURL.h"
     
    4141namespace WebCore {
    4242
    43 AsyncFileWriterChromium::AsyncFileWriterChromium(FileWriterClient* client)
     43AsyncFileWriterChromium::AsyncFileWriterChromium(AsyncFileWriterClient* client)
    4444    : m_client(client)
    4545{
  • trunk/WebKit/chromium/src/AsyncFileWriterChromium.h

    r68152 r68180  
    4646
    4747class Blob;
    48 class FileWriterClient;
     48class AsyncFileWriterClient;
    4949
    5050class AsyncFileWriterChromium : public AsyncFileWriter, public WebKit::WebFileWriterClient {
    5151public:
    52     AsyncFileWriterChromium(FileWriterClient* client);
     52    AsyncFileWriterChromium(AsyncFileWriterClient* client);
    5353    ~AsyncFileWriterChromium();
    5454   
     
    6767private:
    6868    OwnPtr<WebKit::WebFileWriter> m_writer;
    69     FileWriterClient* m_client;
     69    AsyncFileWriterClient* m_client;
    7070};
    7171
Note: See TracChangeset for help on using the changeset viewer.