Changeset 68198 in webkit


Ignore:
Timestamp:
Sep 23, 2010 2:36:18 PM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-09-23 Jeff Schiller <jeffschiller@google.com>

Reviewed by David Hyatt.

Test to confirm that object/iframe/embed backgrounds are transparent for SVG documents
https://bugs.webkit.org/show_bug.cgi?id=10687

  • platform/mac/svg/in-html/by-reference-expected.txt: Added.
  • svg/in-html/by-reference-expected.checksum: Added.
  • svg/in-html/by-reference-expected.png: Added.
  • svg/in-html/by-reference.html: Added.

2010-09-23 Jeff Schiller <jeffschiller@google.com>

Reviewed by David Hyatt.

Ensure that SVG documents included by reference (object, iframe, embed) have transparent
backgrounds (not white). https://bugs.webkit.org/show_bug.cgi?id=10687

Test: svg/in-html/by-reference.html

  • dom/Document.cpp: (WebCore::Document::hasSVGRootNode):
  • dom/Document.h: (WebCore::Document::hasSVGRootNode):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
Location:
trunk
Files:
4 added
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r68197 r68198  
     12010-09-23  Jeff Schiller  <jeffschiller@google.com>
     2
     3        Reviewed by David Hyatt.
     4
     5        Test to confirm that object/iframe/embed backgrounds are transparent for SVG documents
     6        https://bugs.webkit.org/show_bug.cgi?id=10687
     7
     8        * platform/mac/svg/in-html/by-reference-expected.txt: Added.
     9        * svg/in-html/by-reference-expected.checksum: Added.
     10        * svg/in-html/by-reference-expected.png: Added.
     11        * svg/in-html/by-reference.html: Added.
     12
    1132010-09-23  Hans Wennborg  <hans@chromium.org>
    214
  • trunk/WebCore/ChangeLog

    r68197 r68198  
     12010-09-23  Jeff Schiller  <jeffschiller@google.com>
     2
     3        Reviewed by David Hyatt.
     4
     5        Ensure that SVG documents included by reference (object, iframe, embed) have transparent
     6        backgrounds (not white).  https://bugs.webkit.org/show_bug.cgi?id=10687
     7
     8        Test: svg/in-html/by-reference.html
     9
     10        * dom/Document.cpp:
     11        (WebCore::Document::hasSVGRootNode):
     12        * dom/Document.h:
     13        (WebCore::Document::hasSVGRootNode):
     14        * rendering/RenderBoxModelObject.cpp:
     15        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
     16
    1172010-09-23  Hans Wennborg  <hans@chromium.org>
    218
  • trunk/WebCore/dom/Document.cpp

    r68195 r68198  
    40294029    return m_svgExtensions.get();
    40304030}
     4031
     4032bool Document::hasSVGRootNode() const
     4033{
     4034    return documentElement() && documentElement()->hasTagName(SVGNames::svgTag);
     4035}
    40314036#endif
    40324037
  • trunk/WebCore/dom/Document.h

    r67512 r68198  
    386386#if ENABLE(SVG)
    387387    virtual bool isSVGDocument() const { return false; }
     388    bool hasSVGRootNode() const;
    388389#else
    389390    static bool isSVGDocument() { return false; }
     391    static bool hasSVGRootNode() { return false; }
    390392#endif
    391393    virtual bool isPluginDocument() const { return false; }
  • trunk/WebCore/rendering/RenderBoxModelObject.cpp

    r67921 r68198  
    625625                        isOpaqueRoot = body->hasLocalName(framesetTag);
    626626                    }
     627#if ENABLE(SVG)
     628                    else {
     629                        // SVG documents and XML documents with SVG root nodes are transparent.
     630                        isOpaqueRoot = !document()->hasSVGRootNode();
     631                    }
     632#endif
    627633                }
    628634            } else
Note: See TracChangeset for help on using the changeset viewer.