Changeset 68266 in webkit

Timestamp:

Sep 24, 2010 10:17:22 AM (14 years ago)

Author:

ap@apple.com

Message:

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=46380
REGRESSION: Crash when downloading a file

Downloading cannot be tested in DRT.

• Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Don't copy null strings.

Location:

trunk/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• Misc/WebNSFileManagerExtras.m (modified) (1 diff)

trunk/WebKit/mac/ChangeLog

@@ +1 @@
+2010-09-23  Alexey Proskuryakov  <ap@apple.com>
+
+        Reviewed by Darin Adler.
+
+        https://bugs.webkit.org/show_bug.cgi?id=46380
+        REGRESSION: Crash when downloading a file
+
+        Downloading cannot be tested in DRT.
+
+        * Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
+        Don't copy null strings.
+
 2010-09-24  Ilya Tikhonovsky  <loislo@chromium.org>
 

trunk/WebKit/mac/Misc/WebNSFileManagerExtras.m

@@ -127 +127 @@
     MetaDataInfo *info = malloc(sizeof(MetaDataInfo));
     
-    info->URLString = CFStringCreateCopy(0, (CFStringRef)URLString);
-    info->referrer = CFStringCreateCopy(0, (CFStringRef)referrer);
-    info->path = CFStringCreateCopy(0, (CFStringRef)path);
+    info->URLString = URLString ? CFStringCreateCopy(0, (CFStringRef)URLString) : 0;
+    info->referrer = referrer ? CFStringCreateCopy(0, (CFStringRef)referrer) : 0;
+    info->path = path ? CFStringCreateCopy(0, (CFStringRef)path) : 0;
 
     pthread_create(&tid, &attr, setMetaData, info);