Changeset 68344 in webkit


Ignore:
Timestamp:
Sep 26, 2010 10:45:16 AM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-09-26 Renata Hodovan <​reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFEBlendElement doesn't support dynamic invalidation, when attributes change.
​https://bugs.webkit.org/show_bug.cgi?id=46464
Adding layout tests for feBlend dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr.html: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop.html: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-in-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-in2-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-mode-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-in-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-in2-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-mode-prop.js: Added. (executeTest):

2010-09-26 Renata Hodovan <​reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFEBlendElement doesn't support dynamic invalidation, when attributes change.
​https://bugs.webkit.org/show_bug.cgi?id=46464

Tests: svg/dynamic-updates/SVGFEBlendElement-dom-in-attr.html

svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html
svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html

  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::svgAttributeChanged):
  • svg/SVGFEBlendElement.h:
Location:
trunk
Files:
30 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r68343 r68344  
     12010-09-26  Renata Hodovan  <reni@inf.u-szeged.hu>
     2
     3        Reviewed by Dirk Schulze.
     4
     5        SVGFEBlendElement doesn't support dynamic invalidation, when attributes change.
     6        https://bugs.webkit.org/show_bug.cgi?id=46464
     7        Adding layout tests for feBlend dynamic changes.
     8
     9        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
     10        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
     11        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
     12        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
     13        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
     14        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
     15        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
     16        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
     17        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
     18        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
     19        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
     20        * platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
     21        * svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.txt: Added.
     22        * svg/dynamic-updates/SVGFEBlendElement-dom-in-attr.html: Added.
     23        * svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.txt: Added.
     24        * svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html: Added.
     25        * svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.txt: Added.
     26        * svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr.html: Added.
     27        * svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.txt: Added.
     28        * svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop.html: Added.
     29        * svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.txt: Added.
     30        * svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop.html: Added.
     31        * svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.txt: Added.
     32        * svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html: Added.
     33        * svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-in-attr.js: Added.
     34        (executeTest):
     35        * svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-in2-attr.js: Added.
     36        (executeTest):
     37        * svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-mode-attr.js: Added.
     38        (executeTest):
     39        * svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-in-prop.js: Added.
     40        (executeTest):
     41        * svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-in2-prop.js: Added.
     42        (executeTest):
     43        * svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-mode-prop.js: Added.
     44        (executeTest):
     45
    1462010-09-26  Andreas Kling  <andreas.kling@nokia.com>
    247

  • trunk/WebCore/ChangeLog

    r68343 r68344  
     12010-09-26  Renata Hodovan  <reni@inf.u-szeged.hu>
     2
     3        Reviewed by Dirk Schulze.
     4
     5        SVGFEBlendElement doesn't support dynamic invalidation, when attributes change.
     6        https://bugs.webkit.org/show_bug.cgi?id=46464
     7
     8        Tests: svg/dynamic-updates/SVGFEBlendElement-dom-in-attr.html
     9               svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html
     10               svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr.html
     11               svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop.html
     12               svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop.html
     13               svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html
     14
     15        * svg/SVGFEBlendElement.cpp:
     16        (WebCore::SVGFEBlendElement::svgAttributeChanged):
     17        * svg/SVGFEBlendElement.h:
     18
    1192010-09-26  Andreas Kling  <andreas.kling@nokia.com>
    220

  • trunk/WebCore/svg/SVGFEBlendElement.cpp

    r67847 r68344  
    6161}
    6262
     63void SVGFEBlendElement::svgAttributeChanged(const QualifiedName& attrName)
     64{
     65    SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName);
     66
     67    if (attrName == SVGNames::modeAttr
     68        || attrName == SVGNames::inAttr
     69        || attrName == SVGNames::in2Attr)
     70        invalidate();
     71}
     72
    6373void SVGFEBlendElement::synchronizeProperty(const QualifiedName& attrName)
    6474{

  • trunk/WebCore/svg/SVGFEBlendElement.h

    r66397 r68344  
    3535
    3636    virtual void parseMappedAttribute(Attribute*);
     37    virtual void svgAttributeChanged(const QualifiedName&);
    3738    virtual void synchronizeProperty(const QualifiedName&);
    3839    virtual PassRefPtr<FilterEffect> build(SVGFilterBuilder*);
Note: See TracChangeset for help on using the changeset viewer.