Changeset 68382 in webkit

Timestamp:

Sep 27, 2010 4:48:13 AM (14 years ago)

Author:

benjamin.poulain@nokia.com

Message:

2010-09-27 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::popupFocus() randomly fail on MeeGo handset because the focus is not set on the window
​https://bugs.webkit.org/show_bug.cgi?id=46617

This patch avoid the race condition by waiting for the window
to be mapped on screen before attempting any actions.

• tests/qwebframe/tst_qwebframe.cpp:

Location:

trunk/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• tests/qwebframe/tst_qwebframe.cpp (modified) (1 diff)

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-09-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] tst_QWebFrame::popupFocus() randomly fail on MeeGo handset because the focus is not set on the window
+        https://bugs.webkit.org/show_bug.cgi?id=46617
+
+        This patch avoid the race condition by waiting for the window
+        to be mapped on screen before attempting any actions.
+
+        * tests/qwebframe/tst_qwebframe.cpp:
+
 2010-09-24  Luiz Agostini  <luiz.agostini@openbossa.org>
 

trunk/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp

@@ -2605 +2605 @@
     view.resize(400, 100);
     view.show();
+    QTest::qWaitForWindowShown(&view);
     view.setFocus();
     QTRY_VERIFY(view.hasFocus());