Changeset 68682 in webkit

Timestamp:

Sep 29, 2010 1:56:32 PM (14 years ago)

Author:

Joseph Pecoraro

Message:

2010-09-29 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Simon Fraser.

CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
​https://bugs.webkit.org/show_bug.cgi?id=46777

It should not be possible to get to be in the LoadingFromSourceElement
state with a null current source node. This was a possible scenario
where the current source node was cleared but the load state was not
cleared as well. Tried and could not create a test case for this.

• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::userCancelledLoad): clear the load state because we also clear the current source node.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLMediaElement.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-09-29  Joseph Pecoraro  <joepeck@webkit.org>
+
+        Reviewed by Simon Fraser.
+
+        CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
+        https://bugs.webkit.org/show_bug.cgi?id=46777
+
+        It should not be possible to get to be in the LoadingFromSourceElement
+        state with a null current source node. This was a possible scenario
+        where the current source node was cleared but the load state was not
+        cleared as well. Tried and could not create a test case for this.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::userCancelledLoad): clear the load state because we also clear the current source node.
+
 2010-09-29  David Hyatt  <hyatt@apple.com>
 

trunk/WebCore/html/HTMLMediaElement.cpp

@@ -1998 +1998 @@
 #endif
     stopPeriodicTimers();
+    m_loadState = WaitingForSource;
 
     // 2 - Set the error attribute to a new MediaError object whose code attribute is set to MEDIA_ERR_ABORTED.