Changeset 68870 in webkit

Timestamp:

Oct 1, 2010 12:52:36 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-10-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

http/tests/navigation/ping-same-origin.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=46961

This test fails by forgetting to print out the REQUEST_METHOD:

​http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r68727%20(18470)/http/tests/navigation/ping-same-origin-pretty-diff.html

The only way this makes sense is if the file isn't finished writing by
the time it gets read. This can happen because the reader is polling
the file for existence (!) to decide whether to read it.

This patch writes to a temporary location and then moves the finished
bytes into the well-known location atomically. I haven't verified that
it fixes the flakiness, but it seems like a good bet.

• http/tests/navigation/resources/save-ping.php:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/navigation/resources/save-ping.php (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-10-01  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        http/tests/navigation/ping-same-origin.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=46961
+
+        This test fails by forgetting to print out the REQUEST_METHOD:
+
+        http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r68727%20(18470)/http/tests/navigation/ping-same-origin-pretty-diff.html
+
+        The only way this makes sense is if the file isn't finished writing by
+        the time it gets read.  This can happen because the reader is polling
+        the file for existence (!) to decide whether to read it.
+
+        This patch writes to a temporary location and then moves the finished
+        bytes into the well-known location atomically.  I haven't verified that
+        it fixes the flakiness, but it seems like a good bet.
+
+        * http/tests/navigation/resources/save-ping.php:
+
 2010-10-01  Vincent Scheib  <scheib@chromium.org>
 

trunk/LayoutTests/http/tests/navigation/resources/save-ping.php

@@ -1 +1 @@
 <?php
-$pingFile = fopen("ping.txt", 'w');
+$pingFile = fopen("ping.txt.tmp", 'w');
 $httpHeaders = $_SERVER;
 ksort($httpHeaders, SORT_STRING);
@@ -8 +8 @@
 }
 fclose($pingFile);
+rename("ping.txt.tmp", "ping.txt");
 ?>