Changeset 68899 in webkit


Ignore:
Timestamp:
Oct 1, 2010 10:50:39 AM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-10-01 Pratik Solanki <​psolanki@apple.com>

Reviewed by Geoffrey Garen.
Specify ALWAYS_INLINE at function declaration not function definition
​https://bugs.webkit.org/show_bug.cgi?id=46960

For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.

  • bytecompiler/BytecodeGenerator.h:
  • wtf/FastMalloc.cpp:

2010-10-01 Pratik Solanki <​psolanki@apple.com>

Reviewed by Geoffrey Garen.
Specify ALWAYS_INLINE at function declaration not function definition
​https://bugs.webkit.org/show_bug.cgi?id=46960

For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.

  • css/CSSStyleSelector.h:
  • rendering/InlineIterator.h:
  • rendering/style/RenderStyle.h:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/ChangeLog

    r68893 r68899  
     12010-10-01  Pratik Solanki  <psolanki@apple.com>
     2
     3        Reviewed by Geoffrey Garen.
     4        Specify ALWAYS_INLINE at function declaration not function definition
     5        https://bugs.webkit.org/show_bug.cgi?id=46960
     6
     7        For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.
     8
     9        * bytecompiler/BytecodeGenerator.h:
     10        * wtf/FastMalloc.cpp:
     11
    1122010-10-01  Kwang Yul Seo  <skyul@company100.net>
    213

  • trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.h

    r68338 r68899  
    425425        void retrieveLastBinaryOp(int& dstIndex, int& src1Index, int& src2Index);
    426426        void retrieveLastUnaryOp(int& dstIndex, int& srcIndex);
    427         void rewindBinaryOp();
    428         void rewindUnaryOp();
     427        ALWAYS_INLINE void rewindBinaryOp();
     428        ALWAYS_INLINE void rewindUnaryOp();
    429429
    430430        PassRefPtr<Label> emitComplexJumpScopes(Label* target, ControlFlowContext* topScope, ControlFlowContext* bottomScope);

  • trunk/JavaScriptCore/wtf/FastMalloc.cpp

    r67371 r68899  
    21862186  size_t Size() const { return size_; }
    21872187
    2188   void* Allocate(size_t size);
     2188  ALWAYS_INLINE void* Allocate(size_t size);
    21892189  void Deallocate(void* ptr, size_t size_class);
    21902190
    2191   void FetchFromCentralCache(size_t cl, size_t allocationSize);
     2191  ALWAYS_INLINE void FetchFromCentralCache(size_t cl, size_t allocationSize);
    21922192  void ReleaseToCentralCache(size_t cl, int N);
    21932193  void Scavenge();
    … …  
    22902290  // Release an object to spans.
    22912291  // May temporarily release lock_.
    2292   void ReleaseToSpans(void* object);
     2292  ALWAYS_INLINE void ReleaseToSpans(void* object);
    22932293
    22942294  // REQUIRES: lock_ is held
    22952295  // Populate cache by fetching from the page heap.
    22962296  // May temporarily release lock_.
    2297   void Populate();
     2297  ALWAYS_INLINE void Populate();
    22982298
    22992299  // REQUIRES: lock is held.
    … …  
    23082308  // Returns true on success.
    23092309  // May temporarily lock a "random" size class.
    2310   static bool EvictRandomSizeClass(size_t locked_size_class, bool force);
     2310  static ALWAYS_INLINE bool EvictRandomSizeClass(size_t locked_size_class, bool force);
    23112311
    23122312  // REQUIRES: lock_ is *not* held.
    … …  
    37063706
    37073707template <bool crashOnFailure>
    3708 void* malloc(size_t);
     3708ALWAYS_INLINE void* malloc(size_t);
    37093709
    37103710void* fastMalloc(size_t size)
    … …  
    37673767#else
    37683768template <bool crashOnFailure>
    3769 void* calloc(size_t, size_t);
     3769ALWAYS_INLINE void* calloc(size_t, size_t);
    37703770
    37713771void* fastCalloc(size_t n, size_t elem_size)
    … …  
    38313831#else
    38323832template <bool crashOnFailure>
    3833 void* realloc(void*, size_t);
     3833ALWAYS_INLINE void* realloc(void*, size_t);
    38343834
    38353835void* fastRealloc(void* old_ptr, size_t new_size)

  • trunk/WebCore/ChangeLog

    r68897 r68899  
     12010-10-01  Pratik Solanki  <psolanki@apple.com>
     2
     3        Reviewed by Geoffrey Garen.
     4        Specify ALWAYS_INLINE at function declaration not function definition
     5        https://bugs.webkit.org/show_bug.cgi?id=46960
     6
     7        For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.
     8
     9        * css/CSSStyleSelector.h:
     10        * rendering/InlineIterator.h:
     11        * rendering/style/RenderStyle.h:
     12
    1132010-10-01  David Hyatt  <hyatt@apple.com>
    214

  • trunk/WebCore/css/CSSStyleSelector.h

    r68083 r68899  
    110110        void initForStyleResolve(Element*, RenderStyle* parentStyle = 0, PseudoId = NOPSEUDO);
    111111        void initElement(Element*);
    112         RenderStyle* locateSharedStyle();
     112        ALWAYS_INLINE RenderStyle* locateSharedStyle();
    113113        Node* locateCousinList(Element* parent, unsigned depth = 1);
    114114        bool canShareStyleWithElement(Node*);

  • trunk/WebCore/rendering/InlineIterator.h

    r68817 r68899  
    5454
    5555    UChar current() const;
    56     WTF::Unicode::Direction direction() const;
     56    ALWAYS_INLINE WTF::Unicode::Direction direction() const;
    5757
    5858    RenderBlock* block;

  • trunk/WebCore/rendering/style/RenderStyle.h

    r68854 r68899  
    307307
    308308private:
    309     RenderStyle();
     309    ALWAYS_INLINE RenderStyle();
    310310    // used to create the default style.
    311     RenderStyle(bool);
    312     RenderStyle(const RenderStyle&);
     311    ALWAYS_INLINE RenderStyle(bool);
     312    ALWAYS_INLINE RenderStyle(const RenderStyle&);
    313313
    314314public:
Note: See TracChangeset for help on using the changeset viewer.