Changeset 68984 in webkit

Timestamp:

Oct 3, 2010 1:19:34 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-10-03 Adam Barth <​abarth@webkit.org>

Reviewed by Holger Freyther.

All the WebSocket tests crash
​https://bugs.webkit.org/show_bug.cgi?id=47055

This code attempts to hold onto temporary objects using references.
That doesn't work in C++. Instead, we need to actually store the
objects somewhere.

• bindings/js/JSWebSocketCustom.cpp: (WebCore::JSWebSocketConstructor::constructJSWebSocket):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/JSWebSocketCustom.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-03  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Holger Freyther.
+
+        All the WebSocket tests crash
+        https://bugs.webkit.org/show_bug.cgi?id=47055
+
+        This code attempts to hold onto temporary objects using references.
+        That doesn't work in C++. Instead, we need to actually store the
+        objects somewhere.
+
+        * bindings/js/JSWebSocketCustom.cpp:
+        (WebCore::JSWebSocketConstructor::constructJSWebSocket):
+
 2010-10-02  Diego Gonzalez  <diegohcg@webkit.org>
 

trunk/WebCore/bindings/js/JSWebSocketCustom.cpp

@@ -55 +55 @@
         return throwVMError(exec, createSyntaxError(exec, "Not enough arguments"));
 
-    const String& urlString = ustringToString(exec->argument(0).toString(exec));
+    String urlString = ustringToString(exec->argument(0).toString(exec));
     if (exec->hadException())
         return throwVMError(exec, createSyntaxError(exec, "wrong URL"));
-    const KURL& url = context->completeURL(urlString);
+    KURL url = context->completeURL(urlString);
     RefPtr<WebSocket> webSocket = WebSocket::create(context);
     ExceptionCode ec = 0;
@@ -64 +64 @@
         webSocket->connect(url, ec);
     else {
-        const String& protocol = ustringToString(exec->argument(1).toString(exec));
+        String protocol = ustringToString(exec->argument(1).toString(exec));
         if (exec->hadException())
             return JSValue::encode(JSValue());