Changeset 68986 in webkit

Timestamp:

Oct 3, 2010 2:22:44 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-10-03 Adam Barth <​abarth@webkit.org>

Reviewed by Holger Freyther.

ASSERT(m_state = Open); is bad news bears
​https://bugs.webkit.org/show_bug.cgi?id=47057

Added by ap (review by darin) in ​http://trac.webkit.org/changeset/50951
Too bad the compiler doesn't catch these errors. I don't believe this
is possible to test.

• platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::writeStreamCallback):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/cf/SocketStreamHandleCFNet.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-03  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Holger Freyther.
+
+        ASSERT(m_state = Open); is bad news bears
+        https://bugs.webkit.org/show_bug.cgi?id=47057
+
+        Added by ap (review by darin) in http://trac.webkit.org/changeset/50951
+        Too bad the compiler doesn't catch these errors.  I don't believe this
+        is possible to test.
+
+        * platform/network/cf/SocketStreamHandleCFNet.cpp:
+        (WebCore::SocketStreamHandle::writeStreamCallback):
+
 2010-10-03  Adam Barth  <abarth@webkit.org>
 

trunk/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp

@@ -566 +566 @@
         }
 
-        ASSERT(m_state = Open);
+        ASSERT(m_state == Open);
         ASSERT(m_connectingSubstate == Connected);