Changeset 69068 in webkit

Timestamp:

Oct 4, 2010 9:28:54 PM (14 years ago)

Author:

yael.aharon@nokia.com

Message:

2010-10-04 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: select element does not release focus with Spatial Navigation
​https://bugs.webkit.org/show_bug.cgi?id=46896

• fast/events/spatial-navigation/snav-multiple-select-expected.txt: Added.
• fast/events/spatial-navigation/snav-multiple-select.html: Added.
• fast/events/spatial-navigation/snav-single-select-expected.txt: Added.
• fast/events/spatial-navigation/snav-single-select.html: Added.

2010-10-04 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: select element does not release focus with Spatial Navigation
​https://bugs.webkit.org/show_bug.cgi?id=46896

When using Spatial Navigation, once a select element is focused, you cannot use arrow keys
to navigate out of the select element. That is because select element currently uses the
arrow keys to change the selected element.
Change the behavior of select element so it does not change selection, if Spatial Navigation
is on.

This patch is addressing the case where Spatial Navigation is used
in a mobile device, and the flag ENABLE_NO_LISTBOX_RENDERING is on.
In the future we can add support for the case where the flag is off, and
the user needs to traverse the select element inline.

Tests: fast/events/spatial-navigation/snav-multiple-select.html

fast/events/spatial-navigation/snav-single-select.html

• dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/spatial-navigation/snav-multiple-select-expected.txt (added)
• LayoutTests/fast/events/spatial-navigation/snav-multiple-select.html (added)
• LayoutTests/fast/events/spatial-navigation/snav-single-select-expected.txt (added)
• LayoutTests/fast/events/spatial-navigation/snav-single-select.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/SelectElement.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-10-04  Yael Aharon  <yael.aharon@nokia.com>
+
+        Reviewed by Antonio Gomes.
+
+        Spatial Navigation: select element does not release focus with Spatial Navigation
+        https://bugs.webkit.org/show_bug.cgi?id=46896
+
+        * fast/events/spatial-navigation/snav-multiple-select-expected.txt: Added.
+        * fast/events/spatial-navigation/snav-multiple-select.html: Added.
+        * fast/events/spatial-navigation/snav-single-select-expected.txt: Added.
+        * fast/events/spatial-navigation/snav-single-select.html: Added.
+
 2010-10-04  Chang Shu  <chang.shu@nokia.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-04  Yael Aharon  <yael.aharon@nokia.com>
+
+        Reviewed by Antonio Gomes.
+
+        Spatial Navigation: select element does not release focus with Spatial Navigation
+        https://bugs.webkit.org/show_bug.cgi?id=46896
+
+        When using Spatial Navigation, once a select element is focused, you cannot use arrow keys
+        to navigate out of the select element. That is because select element currently uses the
+        arrow keys to change the selected element.
+        Change the behavior of select element so it does not change selection, if Spatial Navigation
+        is on.
+
+        This patch is addressing the case where Spatial Navigation is used 
+        in a mobile device, and the flag ENABLE_NO_LISTBOX_RENDERING is on.
+        In the future we can add support for the case where the flag is off, and
+        the user needs to traverse the select element inline.
+
+        Tests: fast/events/spatial-navigation/snav-multiple-select.html
+               fast/events/spatial-navigation/snav-single-select.html
+
+        * dom/SelectElement.cpp:
+        (WebCore::SelectElement::menuListDefaultEventHandler):
+
 2010-10-04  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
 

trunk/WebCore/dom/SelectElement.cpp

@@ -42 +42 @@
 #include "RenderListBox.h"
 #include "RenderMenuList.h"
+#include "Settings.h"
 #include <wtf/Assertions.h>
 
@@ -555 +556 @@
         }
 #else
+        // When using spatial navigation, we want to be able to navigate away from the select element
+        // when the user hits any of the arrow keys, instead of changing the selection.
+        if (Frame* frame = element->document()->frame()) {
+            if (frame->settings() && frame->settings()->isSpatialNavigationEnabled())
+                return;
+        }
+
         UNUSED_PARAM(htmlForm);
         const Vector<Element*>& listItems = data.listItems(element);