Changeset 69077 in webkit
- Timestamp:
- Oct 4, 2010 10:32:41 PM (13 years ago)
- Location:
- trunk
- Files:
-
- 20 added
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r69076 r69077 1 2010-10-04 Renata Hodovan <reni@inf.u-szeged.hu> 2 3 Reviewed by Andreas Kling. 4 5 SVGFEGaussianBlurElement doesn't support dynamic invalidation, when attributes change. 6 https://bugs.webkit.org/show_bug.cgi?id=47074 7 Adding layout tests for feGaussianBlur dynamic changes. 8 9 * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.checksum: Added. 10 * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png: Added. 11 * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.checksum: Added. 12 * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png: Added. 13 * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.checksum: Added. 14 * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png: Added. 15 * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.checksum: Added. 16 * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png: Added. 17 * svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.txt: Added. 18 * svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr.html: Added. 19 * svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.txt: Added. 20 * svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr.html: Added. 21 * svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.txt: Added. 22 * svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call.html: Added. 23 * svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.txt: Added. 24 * svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop.html: Added. 25 * svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-dom-in-attr.js: Added. 26 (executeTest): 27 * svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-dom-stdDeviation-attr.js: Added. 28 (executeTest): 29 * svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-svgdom-in-prop.js: Added. 30 (executeTest): 31 * svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-svgdom-stdDeviation-call.js: Added. 32 (executeTest): 33 1 34 2010-10-04 Renata Hodovan <reni@inf.u-szeged.hu> 2 35 -
trunk/WebCore/ChangeLog
r69072 r69077 1 2010-10-04 Renata Hodovan <reni@inf.u-szeged.hu> 2 3 Reviewed by Andreas Kling. 4 5 SVGFEGaussianBlurElement doesn't support dynamic invalidation, when attributes change. 6 https://bugs.webkit.org/show_bug.cgi?id=47074 7 The patch also implements the simple setStdDeviation method. 8 9 Tests: svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr.html 10 svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr.html 11 svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call.html 12 svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop.html 13 14 * svg/SVGFEGaussianBlurElement.cpp: 15 (WebCore::SVGFEGaussianBlurElement::setStdDeviation): 16 (WebCore::SVGFEGaussianBlurElement::svgAttributeChanged): 17 * svg/SVGFEGaussianBlurElement.h: 18 1 19 2010-10-04 Patrick Gansterer <paroga@paroga.com> 2 20 -
trunk/WebCore/svg/SVGFEGaussianBlurElement.cpp
r67847 r69077 43 43 } 44 44 45 void SVGFEGaussianBlurElement::setStdDeviation(float , float)45 void SVGFEGaussianBlurElement::setStdDeviation(float x, float y) 46 46 { 47 // FIXME: Needs an implementation. 47 setStdDeviationXBaseValue(x); 48 setStdDeviationYBaseValue(y); 49 invalidate(); 48 50 } 49 51 … … 61 63 else 62 64 SVGFilterPrimitiveStandardAttributes::parseMappedAttribute(attr); 65 } 66 67 void SVGFEGaussianBlurElement::svgAttributeChanged(const QualifiedName& attrName) 68 { 69 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName); 70 71 if (attrName == SVGNames::inAttr 72 || attrName == SVGNames::stdDeviationAttr) 73 invalidate(); 63 74 } 64 75 -
trunk/WebCore/svg/SVGFEGaussianBlurElement.h
r66397 r69077 41 41 42 42 virtual void parseMappedAttribute(Attribute*); 43 virtual void svgAttributeChanged(const QualifiedName&); 43 44 virtual void synchronizeProperty(const QualifiedName&); 44 45 virtual PassRefPtr<FilterEffect> build(SVGFilterBuilder*);
Note: See TracChangeset
for help on using the changeset viewer.