Changeset 69077 in webkit


Ignore:
Timestamp:
Oct 4, 2010 10:32:41 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2010-10-04 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Andreas Kling.

SVGFEGaussianBlurElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47074
Adding layout tests for feGaussianBlur dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr.html: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.txt: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call.html: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-dom-in-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-dom-stdDeviation-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-svgdom-in-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-svgdom-stdDeviation-call.js: Added. (executeTest):

2010-10-04 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Andreas Kling.

SVGFEGaussianBlurElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47074
The patch also implements the simple setStdDeviation method.

Tests: svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr.html

svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr.html
svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call.html
svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop.html

  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::setStdDeviation): (WebCore::SVGFEGaussianBlurElement::svgAttributeChanged):
  • svg/SVGFEGaussianBlurElement.h:
Location:
trunk
Files:
20 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r69076 r69077  
     12010-10-04  Renata Hodovan  <reni@inf.u-szeged.hu>
     2
     3        Reviewed by Andreas Kling.
     4
     5        SVGFEGaussianBlurElement doesn't support dynamic invalidation, when attributes change.
     6        https://bugs.webkit.org/show_bug.cgi?id=47074
     7        Adding layout tests for feGaussianBlur dynamic changes.
     8
     9        * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.checksum: Added.
     10        * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png: Added.
     11        * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.checksum: Added.
     12        * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png: Added.
     13        * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.checksum: Added.
     14        * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png: Added.
     15        * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.checksum: Added.
     16        * platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png: Added.
     17        * svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.txt: Added.
     18        * svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr.html: Added.
     19        * svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.txt: Added.
     20        * svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr.html: Added.
     21        * svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.txt: Added.
     22        * svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call.html: Added.
     23        * svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.txt: Added.
     24        * svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop.html: Added.
     25        * svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-dom-in-attr.js: Added.
     26        (executeTest):
     27        * svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-dom-stdDeviation-attr.js: Added.
     28        (executeTest):
     29        * svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-svgdom-in-prop.js: Added.
     30        (executeTest):
     31        * svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-svgdom-stdDeviation-call.js: Added.
     32        (executeTest):
     33
    1342010-10-04  Renata Hodovan  <reni@inf.u-szeged.hu>
    235
  • trunk/WebCore/ChangeLog

    r69072 r69077  
     12010-10-04  Renata Hodovan  <reni@inf.u-szeged.hu>
     2
     3        Reviewed by Andreas Kling.
     4
     5        SVGFEGaussianBlurElement doesn't support dynamic invalidation, when attributes change.
     6        https://bugs.webkit.org/show_bug.cgi?id=47074
     7        The patch also implements the simple setStdDeviation method.
     8
     9        Tests: svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr.html
     10               svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr.html
     11               svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call.html
     12               svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop.html
     13
     14        * svg/SVGFEGaussianBlurElement.cpp:
     15        (WebCore::SVGFEGaussianBlurElement::setStdDeviation):
     16        (WebCore::SVGFEGaussianBlurElement::svgAttributeChanged):
     17        * svg/SVGFEGaussianBlurElement.h:
     18
    1192010-10-04  Patrick Gansterer  <paroga@paroga.com>
    220
  • trunk/WebCore/svg/SVGFEGaussianBlurElement.cpp

    r67847 r69077  
    4343}
    4444
    45 void SVGFEGaussianBlurElement::setStdDeviation(float, float)
     45void SVGFEGaussianBlurElement::setStdDeviation(float x, float y)
    4646{
    47     // FIXME: Needs an implementation.
     47    setStdDeviationXBaseValue(x);
     48    setStdDeviationYBaseValue(y);
     49    invalidate();
    4850}
    4951
     
    6163    else
    6264        SVGFilterPrimitiveStandardAttributes::parseMappedAttribute(attr);
     65}
     66
     67void SVGFEGaussianBlurElement::svgAttributeChanged(const QualifiedName& attrName)
     68{
     69    SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName);
     70
     71    if (attrName == SVGNames::inAttr
     72        || attrName == SVGNames::stdDeviationAttr)
     73        invalidate();
    6374}
    6475
  • trunk/WebCore/svg/SVGFEGaussianBlurElement.h

    r66397 r69077  
    4141
    4242    virtual void parseMappedAttribute(Attribute*);
     43    virtual void svgAttributeChanged(const QualifiedName&);
    4344    virtual void synchronizeProperty(const QualifiedName&);
    4445    virtual PassRefPtr<FilterEffect> build(SVGFilterBuilder*);
Note: See TracChangeset for help on using the changeset viewer.