Changeset 69096 in webkit

Timestamp:

Oct 5, 2010 1:28:53 AM (14 years ago)

Author:

oliver@apple.com

Message:

2010-10-05 Oliver Hunt <​oliver@apple.com>

Reviewed by Darin Adler.

REGRESSION(r68338): JavaScript error on PowerPC only (crashes on Interpreter built for x86_64)
​https://bugs.webkit.org/show_bug.cgi?id=46690

Use the correct register value when initialising the arguments
object in the interpreter. This is covered by existing tests.

• interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• interpreter/Interpreter.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-10-05  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Darin Adler.
+
+        REGRESSION(r68338): JavaScript error on PowerPC only (crashes on Interpreter built for x86_64)
+        https://bugs.webkit.org/show_bug.cgi?id=46690
+
+        Use the correct register value when initialising the arguments
+        object in the interpreter.  This is covered by existing tests.
+
+        * interpreter/Interpreter.cpp:
+        (JSC::Interpreter::privateExecute):
+
 2010-10-04  David Goodwin  <david_goodwin@apple.com>
 

trunk/JavaScriptCore/interpreter/Interpreter.cpp

@@ -3174 +3174 @@
         if (!arguments) {
             Arguments* arguments = new (globalData) Arguments(callFrame);
-            callFrame->r(dst) = JSValue(arguments);
-            callFrame->r(unmodifiedArgumentsRegister(dst)) = JSValue(arguments);
+            callFrame->r(argumentsRegister) = JSValue(arguments);
+            callFrame->r(unmodifiedArgumentsRegister(argumentsRegister)) = JSValue(arguments);
         }
         // fallthrough