Changeset 69127 in webkit

Timestamp:

Oct 5, 2010 11:20:06 AM (14 years ago)

Author:

cmarrin@apple.com

Message:

2010-10-05 Chris Marrin <​cmarrin@apple.com>

Reviewed by Adam Roben.

Fix ownership of GraphicsContext3D in SharedGraphicsContext3D to prevent early deallocation and crash
​https://bugs.webkit.org/show_bug.cgi?id=47197

This is work in progress and the crash only happens with ACCELERATED_2D_CANVAS turned on (which is off
by default). Many existing test cases will crash before and after this patch.

• platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gpu/SharedGraphicsContext3D.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-05  Chris Marrin  <cmarrin@apple.com>
+
+        Reviewed by Adam Roben.
+
+        Fix ownership of GraphicsContext3D in SharedGraphicsContext3D to prevent early deallocation and crash
+        https://bugs.webkit.org/show_bug.cgi?id=47197
+
+        This is work in progress and the crash only happens with ACCELERATED_2D_CANVAS turned on (which is off
+        by default). Many existing test cases will crash before and after this patch.
+
+        * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
+        (WebCore::SharedGraphicsContext3D::create):
+
 2010-10-05  Tony Chang  <tony@chromium.org>
 

trunk/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp

@@ -56 +56 @@
     if (!context)
         return 0;
-    return adoptRef(new SharedGraphicsContext3D(context.get()));
+    return adoptRef(new SharedGraphicsContext3D(context.release()));
 }