Changeset 69133 in webkit


Ignore:
Timestamp:
Oct 5, 2010 12:01:15 PM (13 years ago)
Author:
robert@webkit.org
Message:

2010-10-05 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix url conversion in QWebHistory

Converting from KURL to WFT::String to QUrl does not
permit proper percent encoding later.

Unskp tests that now pass:

http/tests/navigation/postredirect-goback2.html
http/tests/navigation/error404-frames.html
http/tests/navigation/post-basic.html
http/tests/navigation/post-frames.html
http/tests/navigation/post-goback1.html
http/tests/navigation/anchor-frames.html

These produce only rendertree differences with '--platform mac'.
Unskipping so we can get Qt-specific results from bot:

http/tests/navigation/error404-basic.html
http/tests/navigation/error404-goback.html
http/tests/navigation/error404-subframeload.html
http/tests/navigation/javascriptlink-frames.html
http/tests/navigation/postredirect-basic.html
http/tests/navigation/postredirect-frames.html
http/tests/navigation/postredirect-goback1.html

https://bugs.webkit.org/show_bug.cgi?id=47048

  • platform/qt/Skipped:

2010-10-05 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix url conversion in QWebHistory

Converting from KURL to WFT::String to QUrl does not
permit proper percent encoding later.

https://bugs.webkit.org/show_bug.cgi?id=47048

  • Api/qwebhistory.cpp: (QWebHistoryItem::originalUrl): (QWebHistoryItem::url):

2010-10-05 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix url conversion in QWebHistory

Converting from KURL to WFT::String to QUrl does not
permit proper percent encoding later.

https://bugs.webkit.org/show_bug.cgi?id=47048

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::dumpHistoryItem):
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r69130 r69133  
     12010-10-05  Robert Hogan  <robert@webkit.org>
     2
     3        Reviewed by Andreas Kling.
     4
     5        [Qt] Fix url conversion in QWebHistory
     6
     7        Converting from KURL to WFT::String to QUrl does not
     8        permit proper percent encoding later.
     9
     10        Unskp tests that now pass:
     11         http/tests/navigation/postredirect-goback2.html
     12         http/tests/navigation/error404-frames.html
     13         http/tests/navigation/post-basic.html
     14         http/tests/navigation/post-frames.html
     15         http/tests/navigation/post-goback1.html
     16         http/tests/navigation/anchor-frames.html
     17
     18        These produce only rendertree differences with '--platform mac'.
     19        Unskipping so we can get Qt-specific results from bot:
     20         http/tests/navigation/error404-basic.html
     21         http/tests/navigation/error404-goback.html
     22         http/tests/navigation/error404-subframeload.html
     23         http/tests/navigation/javascriptlink-frames.html
     24         http/tests/navigation/postredirect-basic.html
     25         http/tests/navigation/postredirect-frames.html
     26         http/tests/navigation/postredirect-goback1.html
     27
     28        https://bugs.webkit.org/show_bug.cgi?id=47048
     29
     30        * platform/qt/Skipped:
     31
    1322010-10-05  Tony Chang  <tony@chromium.org>
    233
  • trunk/LayoutTests/platform/qt/Skipped

    r69073 r69133  
    214214http/tests/navigation/no-referrer-reset.html
    215215http/tests/navigation/no-referrer-target-blank.html
    216 
    217 # requires correct URL encoding - webkit.org/b/47048
    218 http/tests/navigation/postredirect-goback2.html
    219 
    220 #new - no expected results
    221 http/tests/navigation/anchor-frames.html
    222 http/tests/navigation/error404-basic.html
    223 http/tests/navigation/error404-frames.html
    224 http/tests/navigation/error404-goback.html
    225 http/tests/navigation/error404-subframeload.html
    226 http/tests/navigation/javascriptlink-frames.html
    227 http/tests/navigation/post-basic.html
    228 http/tests/navigation/post-frames.html
    229 http/tests/navigation/post-goback1.html
    230 http/tests/navigation/postredirect-basic.html
    231 http/tests/navigation/postredirect-frames.html
    232 http/tests/navigation/postredirect-goback1.html
    233216
    234217# time out
  • trunk/WebKit/qt/Api/qwebhistory.cpp

    r65771 r69133  
    104104{
    105105    if (d->item)
    106         return QUrl(d->item->originalURL().string());
     106        return d->item->originalURL();
    107107    return QUrl();
    108108}
     
    117117{
    118118    if (d->item)
    119         return QUrl(d->item->url().string());
     119        return d->item->url();
    120120    return QUrl();
    121121}
  • trunk/WebKit/qt/ChangeLog

    r69111 r69133  
     12010-10-05  Robert Hogan  <robert@webkit.org>
     2
     3        Reviewed by Andreas Kling.
     4
     5        [Qt] Fix url conversion in QWebHistory
     6
     7        Converting from KURL to WFT::String to QUrl does not
     8        permit proper percent encoding later.
     9
     10        https://bugs.webkit.org/show_bug.cgi?id=47048
     11
     12        * Api/qwebhistory.cpp:
     13        (QWebHistoryItem::originalUrl):
     14        (QWebHistoryItem::url):
     15
    1162010-10-05  Jakob Petsovits  <jpetsovits@rim.com>
    217
  • trunk/WebKitTools/ChangeLog

    r69129 r69133  
     12010-10-05  Robert Hogan  <robert@webkit.org>
     2
     3        Reviewed by Andreas Kling.
     4
     5        [Qt] Fix url conversion in QWebHistory
     6
     7        Converting from KURL to WFT::String to QUrl does not
     8        permit proper percent encoding later.
     9
     10        https://bugs.webkit.org/show_bug.cgi?id=47048
     11
     12        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
     13        (WebCore::dumpHistoryItem):
     14
    1152010-10-05  Anders Carlsson  <andersca@apple.com>
    216
  • trunk/WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp

    r68825 r69133  
    831831        result.append(' ');
    832832
    833     QString url = item.url().toString();
     833    QString url = item.url().toEncoded();
    834834    if (url.contains("file://")) {
    835835        static QString layoutTestsString("/LayoutTests/");
Note: See TracChangeset for help on using the changeset viewer.