Changeset 69143 in webkit

Timestamp:

Oct 5, 2010 1:41:15 PM (14 years ago)

Author:

atwilson@chromium.org

Message:

2010-10-05 Andrew Wilson <​atwilson@chromium.org>

Reviewed by Andreas Kling.

Notification onclick() events don't act like user gestures
​https://bugs.webkit.org/show_bug.cgi?id=47137

• src/WebNotification.cpp: (WebKit::WebNotification::dispatchClickEvent): Use UserGestureIndicator to make sure click events are treated like user gestures.

2010-10-05 Andrew Wilson <​atwilson@chromium.org>

Reviewed by Andreas Kling.

Notification onclick() events don't act like user gestures
​https://bugs.webkit.org/show_bug.cgi?id=47137

• WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::notificationClicked): Use UserGestureIndicator to make sure click events are treated like user gestures.

Location:

trunk/WebKit

Files:

• chromium/ChangeLog (modified) (1 diff)
• chromium/src/WebNotification.cpp (modified) (2 diffs)
• qt/ChangeLog (modified) (1 diff)
• qt/WebCoreSupport/NotificationPresenterClientQt.cpp (modified) (2 diffs)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-10-05  Andrew Wilson  <atwilson@chromium.org>
+
+        Reviewed by Andreas Kling.
+
+        Notification onclick() events don't act like user gestures
+        https://bugs.webkit.org/show_bug.cgi?id=47137
+
+        * src/WebNotification.cpp:
+        (WebKit::WebNotification::dispatchClickEvent):
+        Use UserGestureIndicator to make sure click events are treated like user gestures.
+
 2010-10-05  Alok Priyadarshi  <alokp@chromium.org>
 

trunk/WebKit/chromium/src/WebNotification.cpp

@@ -35 +35 @@
 
 #include "Notification.h"
+#include "UserGestureIndicator.h"
 
 #include "WebString.h"
@@ -141 +142 @@
 void WebNotification::dispatchClickEvent()
 {
+    // Make sure clicks on notifications are treated as user gestures.
+    UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
     RefPtr<Event> event = Event::create(eventNames().clickEvent, false, true);
     m_private->dispatchEvent(event.release());

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-10-05  Andrew Wilson  <atwilson@chromium.org>
+
+        Reviewed by Andreas Kling.
+
+        Notification onclick() events don't act like user gestures
+        https://bugs.webkit.org/show_bug.cgi?id=47137
+
+        * WebCoreSupport/NotificationPresenterClientQt.cpp:
+        (WebCore::NotificationPresenterClientQt::notificationClicked):
+        Use UserGestureIndicator to make sure click events are treated like user gestures.
+
 2010-10-05  Robert Hogan  <robert@webkit.org>
 

trunk/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp

@@ -41 +41 @@
 #include "ScriptExecutionContext.h"
 #include "SecurityOrigin.h"
+#include "UserGestureIndicator.h"
 
 #include "qwebframe_p.h"
@@ -263 +264 @@
 {
     Notification* notification =  notificationForWrapper(wrapper);
-    if (notification)
+    if (notification) {
+        // Make sure clicks on notifications are treated as user gestures.
+        UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
         sendEvent(notification, eventNames().clickEvent);
+    }
 }