Changeset 69180 in webkit


Ignore:
Timestamp:
Oct 6, 2010 1:17:57 AM (13 years ago)
Author:
podivilov@chromium.org
Message:

2010-10-06 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add "Set Breakpoint" item to XHR resource context menu.
https://bugs.webkit.org/show_bug.cgi?id=47085

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._contextMenu):
Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r69178 r69180  
     12010-10-06  Pavel Podivilov  <podivilov@chromium.org>
     2
     3        Reviewed by Yury Semikhatsky.
     4
     5        Web Inspector: add "Set Breakpoint" item to XHR resource context menu.
     6        https://bugs.webkit.org/show_bug.cgi?id=47085
     7
     8        * English.lproj/localizedStrings.js:
     9        * inspector/front-end/ResourcesPanel.js:
     10        (WebInspector.ResourcesPanel.prototype._contextMenu):
     11
    1122010-10-05  Kinuko Yasuda  <kinuko@chromium.org>
    213
  • trunk/WebCore/inspector/front-end/ResourcesPanel.js

    r69010 r69180  
    12511251    _contextMenu: function(event)
    12521252    {
    1253         // createBlobURL is enabled conditionally, do not expose resource export if it's not available.
    1254         if (typeof window.createBlobURL !== "function" || !Preferences.resourceExportEnabled)
    1255             return;
    1256 
    12571253        var contextMenu = new WebInspector.ContextMenu();
    12581254        var resourceTreeItem = event.target.enclosingNodeOrSelfWithClass("resource-sidebar-tree-item");
    1259         if (resourceTreeItem && resourceTreeItem.treeElement) {
    1260             var resource = resourceTreeItem.treeElement.representedObject;
    1261             contextMenu.appendItem(WebInspector.UIString("Export to HAR"), this._exportResource.bind(this, resource));
    1262         }
    1263         contextMenu.appendItem(WebInspector.UIString("Export all to HAR"), this._exportAll.bind(this));
     1255        var resource;
     1256        if (resourceTreeItem && resourceTreeItem.treeElement)
     1257            resource = resourceTreeItem.treeElement.representedObject;
     1258
     1259        var needSeparator = false;
     1260        // createBlobURL is enabled conditionally, do not expose resource export if it's not available.
     1261        if (typeof window.createBlobURL === "function" && Preferences.resourceExportEnabled) {
     1262            if (resource)
     1263                contextMenu.appendItem(WebInspector.UIString("Export to HAR"), this._exportResource.bind(this, resource));
     1264            contextMenu.appendItem(WebInspector.UIString("Export all to HAR"), this._exportAll.bind(this));
     1265            needSeparator = true;
     1266        }
     1267
     1268        if (resource && resource.category === WebInspector.resourceCategories.xhr) {
     1269            if (needSeparator)
     1270                contextMenu.appendSeparator();
     1271            contextMenu.appendItem(WebInspector.UIString("Set Breakpoint"), WebInspector.breakpointManager.createXHRBreakpoint.bind(WebInspector.breakpointManager, resource.url));
     1272        }
     1273
    12641274        contextMenu.show(event);
    12651275    },
Note: See TracChangeset for help on using the changeset viewer.