Changeset 69268 in webkit


Ignore:
Timestamp:
Oct 6, 2010 6:42:55 PM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-10-06 Sanjeev Radhakrishnan <​sanjeevr@chromium.org>

Reviewed by Darin Fisher.

Released the pluginNode in PluginDocument::detach() and prevents a memory leak.
​https://bugs.webkit.org/show_bug.cgi?id=47129

  • html/PluginDocument.cpp: (WebCore::PluginDocument::detach):
  • html/PluginDocument.h:
Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r69266 r69268  
     12010-10-06  Sanjeev Radhakrishnan  <sanjeevr@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        Released the pluginNode in PluginDocument::detach() and prevents a memory leak.
     6        https://bugs.webkit.org/show_bug.cgi?id=47129
     7
     8        * html/PluginDocument.cpp:
     9        (WebCore::PluginDocument::detach):
     10        * html/PluginDocument.h:
     11
    1122010-10-06  Vincent Scheib  <scheib@chromium.org>
    213

  • trunk/WebCore/html/PluginDocument.cpp

    r69159 r69268  
    156156}
    157157
     158void PluginDocument::detach()
     159{
     160    // Release the plugin node so that we don't have a circular reference.
     161    m_pluginNode = 0;
     162    HTMLDocument::detach();
     163}
     164
    158165void PluginDocument::cancelManualPluginLoad()
    159166{

  • trunk/WebCore/html/PluginDocument.h

    r69159 r69268  
    4646    virtual bool isPluginDocument() const { return true; }
    4747
     48    virtual void detach();
     49
    4850    void cancelManualPluginLoad();
    4951
Note: See TracChangeset for help on using the changeset viewer.