Changeset 69297 in webkit

Timestamp:

Oct 7, 2010 5:23:04 AM (14 years ago)

Author:

kbalazs@webkit.org

Message:

2010-10-07 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner should be portable
​https://bugs.webkit.org/show_bug.cgi?id=45393

Use only the WebKit API for working with urls.

• WebKitTestRunner/StringFunctions.h: (WTR::createWKURL):
• WebKitTestRunner/TestController.cpp: (WTR::blankURL): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::didFinishLoadForFrame):

2010-10-07 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner should be portable
​https://bugs.webkit.org/show_bug.cgi?id=45393

Introducing additional URL API.

• Shared/API/c/WKURL.cpp: (WKURLCreateWithUTF8CString): (WKURLIsEqual):
• Shared/API/c/WKURL.h:

Location:

trunk

Files:

• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/Shared/API/c/WKURL.cpp (modified) (1 diff)
• WebKit2/Shared/API/c/WKURL.h (modified) (1 diff)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/WebKitTestRunner/StringFunctions.h (modified) (3 diffs)
• WebKitTools/WebKitTestRunner/TestController.cpp (modified) (3 diffs)

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        WebKitTestRunner should be portable
+        https://bugs.webkit.org/show_bug.cgi?id=45393
+
+        Introducing additional URL API.
+        * Shared/API/c/WKURL.cpp:
+        (WKURLCreateWithUTF8CString):
+        (WKURLIsEqual):
+        * Shared/API/c/WKURL.h:
+
 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
 

trunk/WebKit2/Shared/API/c/WKURL.cpp

@@ -34 +34 @@
     return toAPI(WebURL::APIType);
 }
+
+WKURLRef WKURLCreateWithUTF8CString(const char* string)
+{
+    return toAPI(WebURL::create(String::fromUTF8(string)).leakRef());
+}
+
+bool WKURLIsEqual(WKURLRef a, WKURLRef b)
+{
+    return toImpl(a)->string() == toImpl(b)->string();
+}

trunk/WebKit2/Shared/API/c/WKURL.h

@@ -35 +35 @@
 WK_EXPORT WKTypeID WKURLGetTypeID();
 
+WK_EXPORT WKURLRef WKURLCreateWithUTF8CString(const char* string);
+
+WK_EXPORT bool WKURLIsEqual(WKURLRef a, WKURLRef b);
+
 #ifdef __cplusplus
 }

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        WebKitTestRunner should be portable
+        https://bugs.webkit.org/show_bug.cgi?id=45393
+
+        Use only the WebKit API for working with urls.
+        * WebKitTestRunner/StringFunctions.h:
+        (WTR::createWKURL):
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::blankURL):
+        (WTR::TestController::resetStateToConsistentValues):
+        (WTR::TestController::didFinishLoadForFrame):
+
 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/WebKitTools/WebKitTestRunner/StringFunctions.h

@@ -1 +1 @@
 /*
  * Copyright (C) 2010 Apple Inc. All rights reserved.
+ * Copyright (C) 2010 University of Szeged. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -29 +30 @@
 #include <JavaScriptCore/JSRetainPtr.h>
 #include <JavaScriptCore/JavaScript.h>
+#include <sstream>
+#include <string>
 #include <WebKit2/WKRetainPtr.h>
 #include <WebKit2/WKString.h>
-#include <WebKit2/WKStringCF.h>
 #include <WebKit2/WKStringPrivate.h>
 #include <WebKit2/WKURL.h>
-#include <WebKit2/WKURLCF.h>
-#include <sstream>
-#include <string>
 #include <wtf/OwnArrayPtr.h>
 #include <wtf/PassOwnArrayPtr.h>
 #include <wtf/Platform.h>
-#include <wtf/RetainPtr.h>
 #include <wtf/Vector.h>
 
@@ -95 +93 @@
 }
 
-// URL Functions
+// URL creation
 
 inline WKURLRef createWKURL(const char* pathOrURL)
 {
-    RetainPtr<CFStringRef> pathOrURLCFString(AdoptCF, CFStringCreateWithCString(0, pathOrURL, kCFStringEncodingUTF8));
-    RetainPtr<CFURLRef> cfURL;
-    if (CFStringHasPrefix(pathOrURLCFString.get(), CFSTR("http://")) || CFStringHasPrefix(pathOrURLCFString.get(), CFSTR("https://")))
-        cfURL.adoptCF(CFURLCreateWithString(0, pathOrURLCFString.get(), 0));
-    else
-#if PLATFORM(WIN)
-        cfURL.adoptCF(CFURLCreateWithFileSystemPath(0, pathOrURLCFString.get(), kCFURLWindowsPathStyle, false));
-#else
-        cfURL.adoptCF(CFURLCreateWithFileSystemPath(0, pathOrURLCFString.get(), kCFURLPOSIXPathStyle, false));
-#endif
-    return WKURLCreateWithCFURL(cfURL.get());
-}
+    if (strstr(pathOrURL, "http://") || strstr(pathOrURL, "https") || strstr(pathOrURL, "file://"))
+        return WKURLCreateWithUTF8CString(pathOrURL);
 
-inline WKStringRef copyURLString(WKURLRef url)
-{
-    RetainPtr<CFURLRef> cfURL(AdoptCF, WKURLCopyCFURL(0, url));
-    return WKStringCreateWithCFString(CFURLGetString(cfURL.get()));
+    const char* filePrefix = "file://";
+    static const size_t prefixLength = strlen(filePrefix);
+    size_t length = strlen(pathOrURL);
+    OwnArrayPtr<char> buffer = adoptArrayPtr(new char[length + prefixLength + 1]);
+    strcpy(buffer.get(), filePrefix);
+    strcat(buffer.get(), pathOrURL);
+    return WKURLCreateWithUTF8CString(buffer.get());
 }
 

trunk/WebKitTools/WebKitTestRunner/TestController.cpp

@@ -35 +35 @@
 namespace WTR {
 
+static WKURLRef blankURL()
+{
+    static staticBlankURL = WKURLCreateWithUTF8CString("about:blank");
+    retun staticBlankURL;
+}
+
 static TestController* controller;
 
@@ -228 +234 @@
     m_doneResetting = false;
 
-    WKRetainPtr<WKURLRef> url(AdoptWK, createWKURL("about:blank"));
-    WKPageLoadURL(m_mainWebView->page(), url.get());
+    WKPageLoadURL(m_mainWebView->page(), blankURL());
     TestController::runUntil(m_doneResetting);
 }
@@ -296 +301 @@
 
     WKRetainPtr<WKURLRef> wkURL(AdoptWK, WKFrameCopyURL(frame));
-    WKRetainPtr<WKStringRef> wkURLString(AdoptWK, copyURLString(wkURL.get()));
-    if (!WKStringIsEqualToUTF8CString(wkURLString.get(), "about:blank"))
+    if (!WKURLIsEqual(wkURL.get(), blankURL()))
         return;