Changeset 69326 in webkit


Ignore:
Timestamp:
Oct 7, 2010 11:39:50 AM (14 years ago)
Author:
Martin Robinson
Message:

2010-09-21 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
​https://bugs.webkit.org/show_bug.cgi?id=46216

Added tests for this issue.

  • platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt: Added.
  • platform/gtk/fonts/fontconfig-synthetic-bold.html: Added.

2010-10-05 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
​https://bugs.webkit.org/show_bug.cgi?id=46216

Look for the FC_EMBOLDEN property of the FcPattern when constructing
FontPlatformData and use it to enable synthetic bold fonts when necessary.

Test: platform/gtk/fonts/fontconfig-synthetic-bold.html

  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Properly handle the FC_EMBOLDEN property.

2010-09-21 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
​https://bugs.webkit.org/show_bug.cgi?id=46216

  • DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN for DejaVu Serif when there is no bold version available. This is necessary to properly test the property in layout tests.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r69320 r69326  
     12010-09-21  Martin Robinson  <mrobinson@igalia.com>
     2
     3        Reviewed by Chris Fleizach.
     4
     5        [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
     6        https://bugs.webkit.org/show_bug.cgi?id=46216
     7
     8        Added tests for this issue.
     9
     10        * platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt: Added.
     11        * platform/gtk/fonts/fontconfig-synthetic-bold.html: Added.
     12
    1132010-10-05  Martin Robinson  <mrobinson@igalia.com>
    214

  • trunk/WebCore/ChangeLog

    r69321 r69326  
     12010-10-05  Martin Robinson  <mrobinson@igalia.com>
     2
     3        Reviewed by Chris Fleizach.
     4
     5        [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
     6        https://bugs.webkit.org/show_bug.cgi?id=46216
     7
     8        Look for the FC_EMBOLDEN property of the FcPattern when constructing
     9        FontPlatformData and use it to enable synthetic bold fonts when necessary.
     10
     11        Test: platform/gtk/fonts/fontconfig-synthetic-bold.html
     12
     13        * platform/graphics/cairo/FontPlatformDataFreeType.cpp:
     14        (WebCore::FontPlatformData::FontPlatformData): Properly handle the FC_EMBOLDEN property.
     15
    1162010-10-07  James Simonsen  <simonjam@chromium.org>
    217

  • trunk/WebCore/platform/graphics/cairo/FontPlatformDataFreeType.cpp

    r69320 r69326  
    107107    if (FcPatternGetInteger(pattern, FC_SPACING, 0, &spacing) == FcResultMatch && spacing == FC_MONO)
    108108        m_fixedWidth = true;
     109
     110    if (fontDescription.weight() >= FontWeightBold) {
     111        // The FC_EMBOLDEN property instructs us to fake the boldness of the font.
     112        FcBool fontConfigEmbolden;
     113        if (FcPatternGetBool(pattern, FC_EMBOLDEN, 0, &fontConfigEmbolden) == FcResultMatch)
     114            m_syntheticBold = fontConfigEmbolden;
     115    }
    109116}
    110117

  • trunk/WebKitTools/ChangeLog

    r69324 r69326  
     12010-09-21  Martin Robinson  <mrobinson@igalia.com>
     2
     3        Reviewed by Chris Fleizach.
     4
     5        [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
     6        https://bugs.webkit.org/show_bug.cgi?id=46216
     7
     8        * DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN
     9        for DejaVu Serif when there is no bold version available. This is necessary to
     10        properly test the property in layout tests.
     11
    1122010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
    213

  • trunk/WebKitTools/DumpRenderTree/gtk/fonts/fonts.conf

    r68558 r69326  
    212212        <edit name="rgba" mode="assign">
    213213            <const>none</const>
     214        </edit>
     215    </match>
     216
     217    <!-- We need to enable simulated bold to for DejaVu Serif to ensure that we interpret
     218         this property correctly in: platform/gtk/fonts/fontconfig-synthetic-bold.html -->
     219    <match target="font">
     220        <test qual="any" name="family">
     221            <string>DejaVu Serif</string>
     222        </test>
     223        <test name="weight" compare="less_eq">
     224            <const>medium</const>
     225        </test>
     226        <test target="pattern" name="weight" compare="more">
     227            <const>medium</const>
     228        </test>
     229        <edit name="embolden" mode="assign">
     230            <bool>true</bool>
     231        </edit>
     232        <edit name="weight" mode="assign">
     233            <const>bold</const>
    214234        </edit>
    215235    </match>
Note: See TracChangeset for help on using the changeset viewer.