Changeset 69447 in webkit

Timestamp:

Oct 9, 2010 8:17:25 AM (14 years ago)

Author:

Martin Robinson

Message:

2010-10-09 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Slider padding translate into a larger track rect
​https://bugs.webkit.org/show_bug.cgi?id=47435

Added a pixel test result for this issue.

• platform/gtk/fast/forms/slider-padding-expected.checksum: Added.
• platform/gtk/fast/forms/slider-padding-expected.png: Added.

2010-10-09 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Slider padding translate into a larger track rect
​https://bugs.webkit.org/show_bug.cgi?id=47435

Instead of painting the track rectangle for ranges onto the entire RenderBox
rectangle, simply paint it on the content rectangle. This prevents misrendering
sliders with padding.

• platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintSliderTrack): Paint onto the absoluteContentRect of the slider instead of the entire area (which includes padding).

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/fast/forms/slider-padding-expected.checksum (added)
• LayoutTests/platform/gtk/fast/forms/slider-padding-expected.png (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/gtk/RenderThemeGtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-10-09  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Xan Lopez.
+
+        [GTK] Slider padding translate into a larger track rect
+        https://bugs.webkit.org/show_bug.cgi?id=47435
+
+        Added a pixel test result for this issue.
+
+        * platform/gtk/fast/forms/slider-padding-expected.checksum: Added.
+        * platform/gtk/fast/forms/slider-padding-expected.png: Added.
+
 2010-10-09  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-09  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Xan Lopez.
+
+        [GTK] Slider padding translate into a larger track rect
+        https://bugs.webkit.org/show_bug.cgi?id=47435
+
+        Instead of painting the track rectangle for ranges onto the entire RenderBox
+        rectangle, simply paint it on the content rectangle. This prevents misrendering
+        sliders with padding.
+
+        * platform/gtk/RenderThemeGtk.cpp:
+        (WebCore::RenderThemeGtk::paintSliderTrack): Paint onto the absoluteContentRect
+        of the slider instead of the entire area (which includes padding).
+
 2010-10-09  Kent Tamura  <tkent@chromium.org>
 

trunk/WebCore/platform/gtk/RenderThemeGtk.cpp

@@ -550 +550 @@
         gtkPart = MOZ_GTK_SCALE_VERTICAL;
 
-    return paintRenderObject(gtkPart, object, info.context, rect);
+    return paintRenderObject(gtkPart, object, info.context, toRenderBox(object)->absoluteContentBox());
 }