Changeset 69459 in webkit

Timestamp:

Oct 9, 2010 2:30:22 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-10-09 Varun Jain <​varunjain@chromium.org>

Reviewed by Darin Fisher.

Adding one method to the WebView interface: method to inform the
renderer to scroll the currently focused element into view, for
instance, when it is hidden due to window resizing.
Also adding methods to WebNode and WebElement to expose more
features of the underlying WebCore::Node.
​https://bugs.webkit.org/show_bug.cgi?id=46296

• public/WebElement.h:
• public/WebNode.h:
• public/WebView.h:
• src/WebElement.h: (WebKit::WebElement::isTextFormControlElement):
• src/WebNode.cpp: (WebKit::WebNode::isContentEditable):
• src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollFocusedNodeIntoView):
• src/WebViewImpl.h:

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebElement.h (modified) (1 diff)
• public/WebNode.h (modified) (1 diff)
• public/WebView.h (modified) (1 diff)
• src/WebElement.cpp (modified) (1 diff)
• src/WebNode.cpp (modified) (2 diffs)
• src/WebViewImpl.cpp (modified) (1 diff)
• src/WebViewImpl.h (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-10-09  Varun Jain  <varunjain@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        Adding one method to the WebView interface: method to inform the
+        renderer to scroll the currently focused element into view, for
+        instance, when it is hidden due to window resizing.
+        Also adding methods to WebNode and WebElement to expose more
+        features of the underlying WebCore::Node.
+        https://bugs.webkit.org/show_bug.cgi?id=46296
+
+        * public/WebElement.h:
+        * public/WebNode.h:
+        * public/WebView.h:
+        * src/WebElement.h:
+        (WebKit::WebElement::isTextFormControlElement):
+        * src/WebNode.cpp:
+        (WebKit::WebNode::isContentEditable):
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::scrollFocusedNodeIntoView):
+        * src/WebViewImpl.h:
+
 2010-10-08  Andrei Popescu  <andreip@google.com>
 

trunk/WebKit/chromium/public/WebElement.h

@@ -51 +51 @@
 
         WEBKIT_API bool isFormControlElement() const;
+        WEBKIT_API bool isTextFormControlElement() const;
         WEBKIT_API WebString tagName() const;
         WEBKIT_API bool hasTagName(const WebString&) const;

trunk/WebKit/chromium/public/WebNode.h

@@ -97 +97 @@
     WEBKIT_API WebString createMarkup() const;
     WEBKIT_API bool isTextNode() const;
+    WEBKIT_API bool isContentEditable() const;
     WEBKIT_API bool isElementNode() const;
     WEBKIT_API void addEventListener(const WebString& eventType, WebDOMEventListener* listener, bool useCapture);

trunk/WebKit/chromium/public/WebView.h

@@ -162 +162 @@
     virtual void clearFocusedNode() = 0;
 
+    // Scrolls the node currently in focus into view.
+    virtual void scrollFocusedNodeIntoView() = 0;
+
 
     // Zoom ----------------------------------------------------------------

trunk/WebKit/chromium/src/WebElement.cpp

@@ -46 +46 @@
 {
     return constUnwrap<Element>()->isFormControlElement();
+}
+
+bool WebElement::isTextFormControlElement() const
+{
+    return constUnwrap<Element>()->isTextFormControl();
 }
 

trunk/WebKit/chromium/src/WebNode.cpp

@@ -33 +33 @@
 
 #include "Document.h"
+#include "Element.h"
 #include "Frame.h"
 #include "FrameLoaderClientImpl.h"
@@ -145 +146 @@
 }
 
+bool WebNode::isContentEditable() const
+{
+    return m_private->isContentEditable();
+}
+
 bool WebNode::isElementNode() const
 {

trunk/WebKit/chromium/src/WebViewImpl.cpp

@@ -1526 +1526 @@
 }
 
+void WebViewImpl::scrollFocusedNodeIntoView()
+{
+    Node* focusedNode = focusedWebCoreNode();
+    if (focusedNode && focusedNode->isElementNode()) {
+        Element* elementNode = static_cast<Element*>(focusedNode);
+        elementNode->scrollIntoViewIfNeeded(true);
+    }
+}
+
 double WebViewImpl::zoomLevel()
 {

trunk/WebKit/chromium/src/WebViewImpl.h

@@ -133 +133 @@
     virtual void setInitialFocus(bool reverse);
     virtual void clearFocusedNode();
+    virtual void scrollFocusedNodeIntoView();
     virtual double zoomLevel();
     virtual double setZoomLevel(bool textOnly, double zoomLevel);