Changeset 69464 in webkit

Timestamp:

Oct 9, 2010 9:17:05 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-10-09 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Exception in committers-autocomplete in Firefox
​https://bugs.webkit.org/show_bug.cgi?id=47456

Remove dependency on a WebKit-only quirk. IMHO, this quirk is bad for
the long-term health of the web, but that's a discussion for another
patch.

• committers-autocomplete.js:

Location:

trunk/BugsSite

Files:

• ChangeLog (modified) (1 diff)
• committers-autocomplete.js (modified) (3 diffs)

trunk/BugsSite/ChangeLog

@@ +1 @@
+2010-10-09  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Exception in committers-autocomplete in Firefox
+        https://bugs.webkit.org/show_bug.cgi?id=47456
+
+        Remove dependency on a WebKit-only quirk.  IMHO, this quirk is bad for
+        the long-term health of the web, but that's a discussion for another
+        patch.
+
+        * committers-autocomplete.js:
+
 2010-10-08  Adam Barth  <abarth@webkit.org>
 

trunk/BugsSite/committers-autocomplete.js

@@ -278 +278 @@
                 selectItem(getIndex(e.target));
                 e.preventDefault();
-            });
+            }, false);
 
             menu.addEventListener('mouseup', function(e) {
                 if (m_selectedIndex == getIndex(e.target))
                     insertSelectedItem();
-            });
+            }, false);
             
             m_menus[name] = menu;
@@ -373 +373 @@
             createMenu(m_focusedInput.name);
             m_focusedInput.setAttribute('autocomplete', 'off');
-            m_focusedInput.addEventListener('keyup', handleKeyUp);
-            m_focusedInput.addEventListener('keydown', handleKeyDown);
+            m_focusedInput.addEventListener('keyup', handleKeyUp, false);
+            m_focusedInput.addEventListener('keydown', handleKeyDown, false);
             m_focusedInput.addEventListener('blur', function() {
                 showMenu(false);
                 m_prefix = null;
                 m_selectedIndex = 0;
-            });
+            }, false);
         }
         
@@ -392 +392 @@
             }
         }
-    });
+    }, false);
 
     WebKitCommitters.getCommitters(function (committers) {