Changeset 69469 in webkit

Timestamp:

Oct 10, 2010 12:46:12 PM (14 years ago)

Author:

mihaip@chromium.org

Message:

2010-10-10 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

<a ping> tests are slow
​https://bugs.webkit.org/show_bug.cgi?id=47431

The ping tests showed up as being flaky in Adam Barth's email; this
might just be due to them being on the slow side due to the 1 second
refresh in check-ping.php. We can instead switch to using file_exists
in a loop if we invalidate the file status cache. Running the three
ping tests with --iterations=10 now takes 4 seconds instead of 23.

This surfaces a race condition in image-load-in-unload-handler.html
(we don't start sending data till we get the ping, but unload handlers
(where the ping is sent) aren't run till we start getting data). Fixed
by adding a dummy page in between.

• http/tests/navigation/resources/check-ping.php:
• http/tests/navigation/image-load-in-unload-handler.html:
• http/tests/navigation/resources/ping-redirect.html: Added.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/navigation/image-load-in-unload-handler.html (modified) (1 diff)
• http/tests/navigation/resources/check-ping.php (modified) (1 diff)
• http/tests/navigation/resources/ping-redirect.html (added)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-10-10  Mihai Parparita  <mihaip@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        <a ping> tests are slow
+        https://bugs.webkit.org/show_bug.cgi?id=47431
+        
+        The ping tests showed up as being flaky in Adam Barth's email; this
+        might just be due to them being on the slow side due to the 1 second
+        refresh in check-ping.php. We can instead switch to using file_exists
+        in a loop if we invalidate the file status cache. Running the three
+        ping tests with --iterations=10 now takes 4 seconds instead of 23.
+        
+        This surfaces a race condition in image-load-in-unload-handler.html
+        (we don't start sending data till we get the ping, but unload handlers
+        (where the ping is sent) aren't run till we start getting data). Fixed
+        by adding a dummy page in between.
+
+        * http/tests/navigation/resources/check-ping.php:
+        * http/tests/navigation/image-load-in-unload-handler.html:
+        * http/tests/navigation/resources/ping-redirect.html: Added.
+
 2010-10-10  Robert Hogan  <robert@webkit.org>
 

trunk/LayoutTests/http/tests/navigation/image-load-in-unload-handler.html

@@ -14 +14 @@
         return;
     }
-    location.assign("resources/check-ping.php");
+    // We can't go to check-ping.php directly, since that doesn't start sending
+    // a response until the ping data is detected, but unload handlers (where
+    // we send the ping) are only run once we've begun receiving data from the
+    // page being navigated to. Instead, we go through a dummy redirect page,
+    // to make sure that the onunload handler has run before we get to 
+    // check-ping.php.
+    location.assign("resources/ping-redirect.html");
 }
 

trunk/LayoutTests/http/tests/navigation/resources/check-ping.php

@@ -1 +1 @@
 <?php
-if (!file_exists("ping.txt")) {
-    $page = $_SERVER['PHP_SELF'];
-    // This refresh header is unfortunate, but if the file doesn't
-    // exist when this php script starts running, it won't notice
-    // its creation even if we sleep and check again.
-    header("Refresh: 1; url=$page");
-    return;
+while (!file_exists("ping.txt")) {
+    usleep(10000);
+    // file_exists() caches results, we want to invalidate the cache.
+    clearstatcache();
 }