Changeset 69582 in webkit

Timestamp:

Oct 12, 2010 7:47:24 AM (14 years ago)

Author:

yael.aharon@nokia.com

Message:

2010-10-12 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Editing commands should not be executed on non-editable content.
​https://bugs.webkit.org/show_bug.cgi?id=47426

• fast/events/scroll-after-click-on-tab-index-expected.txt: Added.
• fast/events/scroll-after-click-on-tab-index.html: Added.

2010-10-12 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Editing commands should not be executed on non-editable content.
​https://bugs.webkit.org/show_bug.cgi?id=47426

Remove calls to editor()->command() when we are not in editable content.
There is no value in doing that, and in some cases, it prevents scrolling.

• WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/scroll-after-click-on-tab-index-expected.txt (added)
• LayoutTests/fast/events/scroll-after-click-on-tab-index.html (added)
• WebKit/qt/ChangeLog (modified) (1 diff)
• WebKit/qt/WebCoreSupport/EditorClientQt.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-10-12  Yael Aharon  <yael.aharon@nokia.com>
+
+        Reviewed by Antonio Gomes.
+
+        [Qt] Editing commands should not be executed on non-editable content.
+        https://bugs.webkit.org/show_bug.cgi?id=47426
+
+        * fast/events/scroll-after-click-on-tab-index-expected.txt: Added.
+        * fast/events/scroll-after-click-on-tab-index.html: Added.
+
 2010-10-12  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-10-12  Yael Aharon  <yael.aharon@nokia.com>
+
+        Reviewed by Antonio Gomes.
+
+        [Qt] Editing commands should not be executed on non-editable content.
+        https://bugs.webkit.org/show_bug.cgi?id=47426
+
+        Remove calls to editor()->command() when we are not in editable content.
+        There is no value in doing that, and in some cases, it prevents scrolling.
+
+        * WebCoreSupport/EditorClientQt.cpp:
+        (WebCore::EditorClientQt::handleKeyboardEvent):
+
 2010-10-08  Hui Huang  <hui.2.huang@nokia.com>
 

trunk/WebKit/qt/WebCoreSupport/EditorClientQt.cpp

@@ -458 +458 @@
         else
 #endif // QT_NO_SHORTCUT
-        switch (kevent->windowsVirtualKeyCode()) {
-        case VK_UP:
-            frame->editor()->command("MoveUp").execute();
-            break;
-        case VK_DOWN:
-            frame->editor()->command("MoveDown").execute();
-            break;
-        case VK_PRIOR: // PageUp
-            frame->editor()->command("MovePageUp").execute();
-            break;
-        case VK_NEXT: // PageDown
-            frame->editor()->command("MovePageDown").execute();
-            break;
-        case VK_HOME:
-            if (kevent->ctrlKey())
-                frame->editor()->command("MoveToBeginningOfDocument").execute();
-            break;
-        case VK_END:
-            if (kevent->ctrlKey())
-                frame->editor()->command("MoveToEndOfDocument").execute();
-            break;
-        default:
-            if (kevent->ctrlKey()) {
-                switch (kevent->windowsVirtualKeyCode()) {
-                case VK_A:
-                    frame->editor()->command("SelectAll").execute();
-                    break;
-                default:
-                    return;
-                }
-            } else
-                return;
-        }
+            return;
     }
     event->setDefaultHandled();