Changeset 69602 in webkit


Ignore:
Timestamp:
Oct 12, 2010 2:12:27 PM (13 years ago)
Author:
Girish Ramakrishnan
Message:

[Qt] Windowless mode 64-bit Flash/X11 freezes when right-click is sent.

Reviewed by Ariya Hidayat.

Adds a new quirk PluginQuirkIgnoreRightClickInWindowlessMode. This
quirk is enabled only for 64-bit Flash/X11 and should not affect other
plugins. The freeze itself is in Flash code and the backtrace is not
useful.

https://bugs.webkit.org/show_bug.cgi?id=47545

  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::determineQuirks):

  • plugins/PluginQuirkSet.h:
  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::handleMouseEvent):

Location:
trunk/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r69599 r69602  
     12010-10-12  Girish Ramakrishnan  <girish@forwardbias.in>
     2
     3        Reviewed by Ariya Hidayat.
     4
     5        [Qt] Windowless mode 64-bit Flash/X11 freezes when right-click is sent.
     6
     7        Adds a new quirk PluginQuirkIgnoreRightClickInWindowlessMode. This
     8        quirk is enabled only for 64-bit Flash/X11 and should not affect other
     9        plugins. The freeze itself is in Flash code and the backtrace is not
     10        useful.
     11
     12        https://bugs.webkit.org/show_bug.cgi?id=47545
     13
     14        * plugins/PluginPackage.cpp:
     15        (WebCore::PluginPackage::determineQuirks):
     16        * plugins/PluginQuirkSet.h:
     17        * plugins/qt/PluginViewQt.cpp:
     18        (WebCore::PluginView::handleMouseEvent):
     19
    1202010-10-08  Simon Fraser  <simon.fraser@apple.com>
    221
  • trunk/WebCore/plugins/PluginPackage.cpp

    r69149 r69602  
    210210        // Flash will crash on repeated calls to SetWindow in windowed mode
    211211        m_quirks.add(PluginQuirkDontCallSetWindowMoreThanOnce);
     212
     213#if CPU(X86_64)
     214        // 64-bit Flash freezes if right-click is sent in windowless mode
     215        m_quirks.add(PluginQuirkIgnoreRightClickInWindowlessMode);
     216#endif
    212217#endif
    213218
  • trunk/WebCore/plugins/PluginQuirkSet.h

    r62185 r69602  
    4848        PluginQuirkRequiresGtkToolKit = 1 << 12,
    4949        PluginQuirkRequiresDefaultScreenDepth = 1 << 13,
    50         PluginQuirkDontCallSetWindowMoreThanOnce = 1 << 14
     50        PluginQuirkDontCallSetWindowMoreThanOnce = 1 << 14,
     51        PluginQuirkIgnoreRightClickInWindowlessMode = 1 << 15
    5152    };
    5253
  • trunk/WebCore/plugins/qt/PluginViewQt.cpp

    r69518 r69602  
    508508        return;
    509509
     510    if (event->button() == RightButton && m_plugin->quirks().contains(PluginQuirkIgnoreRightClickInWindowlessMode))
     511        return;
     512
    510513    if (event->type() == eventNames().mousedownEvent) {
    511514        // Give focus to the plugin on click
Note: See TracChangeset for help on using the changeset viewer.