Changeset 69609 in webkit

Timestamp:

Oct 12, 2010 3:05:53 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-10-12 Kavita Kanetkar <​kkanetkar@chromium.org>

Reviewed by Dumitru Daniliuc.

[FileSystem] Add ability to pass a bool to create or not create root path while opening filesystem.
​https://bugs.webkit.org/show_bug.cgi?id=47519

• public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::openFileSystem):
• public/WebFrameClient.h: (WebKit::WebFrameClient::openFileSystem):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebCommonWorkerClient.h (modified) (1 diff)
• public/WebFrameClient.h (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-10-12  Kavita Kanetkar  <kkanetkar@chromium.org>
+
+        Reviewed by Dumitru Daniliuc.
+
+        [FileSystem] Add ability to pass a bool to create or not create root path while opening filesystem.
+        https://bugs.webkit.org/show_bug.cgi?id=47519
+
+        * public/WebCommonWorkerClient.h:
+        (WebKit::WebCommonWorkerClient::openFileSystem):
+        * public/WebFrameClient.h:
+        (WebKit::WebFrameClient::openFileSystem):
+
 2010-10-12  James Robinson  <jamesr@chromium.org>
 

trunk/WebKit/chromium/public/WebCommonWorkerClient.h

@@ -88 +88 @@
 
     // Called on the main webkit thread before opening a file system.
+    virtual void openFileSystem(WebFileSystem::Type, long long size, bool create, WebFileSystemCallbacks*)
+    {
+        WEBKIT_ASSERT_NOT_REACHED();
+    }
+
+    // This will be removed once changes in chromium use the new method above.
     virtual void openFileSystem(WebFileSystem::Type, long long size, WebFileSystemCallbacks*)
     {

trunk/WebKit/chromium/public/WebFrameClient.h

@@ -350 +350 @@
     // a name and root path for the requested FileSystem when the operation
     // is completed successfully. WebFileSystemCallbacks::didFail() must be
-    // called otherwise.
+    // called otherwise. The create bool is for indicating whether or not to
+    // create root path for file systems if it do not exist.
+    virtual void openFileSystem(
+        WebFrame*, WebFileSystem::Type, long long size,
+        bool create, WebFileSystemCallbacks*) { }
+
+    // This method will be deleted once chromium uses the new method above.
     virtual void openFileSystem(
         WebFrame*, WebFileSystem::Type, long long size,