Changeset 69670 in webkit

Timestamp:

Oct 13, 2010 10:26:50 AM (14 years ago)

Author:

andreip@google.com

Message:

2010-10-11 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[Chromium] Cleanup WebIDBFactory::open once the Chromium plumbing has landed.
​https://bugs.webkit.org/show_bug.cgi?id=47531

Remove the temporary open() method since the appropriate Chromium plumbing was
added in ​http://codereview.chromium.org/3729003/

• public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebIDBFactory.h (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-10-11  Andrei Popescu  <andreip@google.com>
+
+        Reviewed by Jeremy Orlow.
+
+        [Chromium] Cleanup WebIDBFactory::open once the Chromium plumbing has landed.
+        https://bugs.webkit.org/show_bug.cgi?id=47531
+
+        Remove the temporary open() method since the appropriate Chromium plumbing was
+        added in http://codereview.chromium.org/3729003/
+
+        * public/WebIDBFactory.h:
+        (WebKit::WebIDBFactory::open):
+
 2010-10-13  Adam Barth  <abarth@webkit.org>
 

trunk/WebKit/chromium/public/WebIDBFactory.h

@@ -55 +55 @@
     virtual void open(const WebString& name, const WebString& description, WebIDBCallbacks* callbacks, const WebSecurityOrigin& origin, WebFrame* webFrame, const WebString& dataDir, unsigned long long maximumSize)
     {
-        // FIXME: Remove the line below and renable this assertion.
-        open(name, description, callbacks, origin, webFrame, dataDir);
-        // WEBKIT_ASSERT_NOT_REACHED();
-    }
-    // FIXME: Remove once we update Chromium side.
-    virtual void open(const WebString& name, const WebString& description, WebIDBCallbacks* callbacks, const WebSecurityOrigin& origin, WebFrame* webFrame, const WebString& dataDir)
-    {
-        open(name, description, callbacks, origin, webFrame, dataDir, 5 * 1024 * 1024);
+        WEBKIT_ASSERT_NOT_REACHED();
     }